Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor subview components into TSX #793

Merged
merged 3 commits into from
Dec 29, 2022

Conversation

MikuroXina
Copy link
Collaborator

@MikuroXina MikuroXina commented Dec 29, 2022

Separated from #790.

@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Base: 88.28% // Head: 88.28% // No change to project coverage 👍

Coverage data is based on head (3634f22) compared to base (740b90d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files         175      175           
  Lines        5293     5293           
  Branches      271      271           
=======================================
  Hits         4673     4673           
  Misses        585      585           
  Partials       35       35           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@dtinth
Copy link
Member

dtinth commented Dec 29, 2022

I am revamping the release process a bit based on what I learned from using Changesets in other projects. I’ll go ahead and merge this one now.

@dtinth dtinth merged commit 16569e0 into bemusic:master Dec 29, 2022
@MikuroXina MikuroXina deleted the refactor/subview-ui branch December 29, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants