-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor some main components #795
Conversation
Codecov ReportBase: 88.28% // Head: 88.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #795 +/- ##
==========================================
- Coverage 88.28% 88.27% -0.02%
==========================================
Files 175 175
Lines 5293 5295 +2
Branches 271 271
==========================================
+ Hits 4673 4674 +1
- Misses 585 586 +1
Partials 35 35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
80c8d5a
to
0461c76
Compare
1ed588e
to
d7e425f
Compare
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the features related to the changed files, seems to work great. Thanks so much!
@MikuroXina I’ve just sent you an invite to collaborate on Bemuse. https://github.com/bemusic/bemuse/invitations |
@dtinth I've accepted, thanks for invitation! However, may I continue to contribute with my fork repository? |
@MikuroXina Of course, you can contribute in any way you are comfortable with. 😃 |
Separated from #790. The fixes which needs some improvements of the state management are not included.