Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some main components #795

Merged
merged 9 commits into from
Dec 30, 2022
Merged

Conversation

MikuroXina
Copy link
Collaborator

Separated from #790. The fixes which needs some improvements of the state management are not included.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Base: 88.28% // Head: 88.27% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (5a5fa8d) compared to base (28494e4).
Patch coverage: 11.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
- Coverage   88.28%   88.27%   -0.02%     
==========================================
  Files         175      175              
  Lines        5293     5295       +2     
  Branches      271      271              
==========================================
+ Hits         4673     4674       +1     
- Misses        585      586       +1     
  Partials       35       35              
Impacted Files Coverage Δ
bemuse/src/devtools/ui/BenchmarkPanel.tsx 11.76% <11.76%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MikuroXina MikuroXina force-pushed the refactor/app-ui branch 9 times, most recently from 80c8d5a to 0461c76 Compare December 29, 2022 17:21
@MikuroXina MikuroXina changed the title Refactor app components Refactor some main components Dec 29, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the features related to the changed files, seems to work great. Thanks so much!

@dtinth dtinth merged commit 1cd29b0 into bemusic:master Dec 30, 2022
@MikuroXina MikuroXina deleted the refactor/app-ui branch December 30, 2022 04:32
@dtinth
Copy link
Member

dtinth commented Dec 30, 2022

@MikuroXina I’ve just sent you an invite to collaborate on Bemuse. https://github.com/bemusic/bemuse/invitations

@MikuroXina
Copy link
Collaborator Author

@dtinth I've accepted, thanks for invitation! However, may I continue to contribute with my fork repository?

@dtinth
Copy link
Member

dtinth commented Dec 30, 2022

@MikuroXina Of course, you can contribute in any way you are comfortable with. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants