Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor state management #805

Merged
merged 13 commits into from
Dec 31, 2022
Merged

Conversation

MikuroXina
Copy link
Collaborator

Separated from #790. This is a preparation to fix components which depend on the state system.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Base: 88.27% // Head: 87.46% // Decreases project coverage by -0.80% ⚠️

Coverage data is based on head (76a0191) compared to base (8ad76a5).
Patch coverage: 73.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
- Coverage   88.27%   87.46%   -0.81%     
==========================================
  Files         175      178       +3     
  Lines        5295     5395     +100     
  Branches      271      302      +31     
==========================================
+ Hits         4674     4719      +45     
- Misses        586      635      +49     
- Partials       35       41       +6     
Impacted Files Coverage Δ
bemuse/src/app/redux/collectionLoader.ts 61.53% <61.53%> (ø)
bemuse/src/app/entities/Options.ts 63.69% <63.69%> (ø)
bemuse/src/app/redux/optionsStorageMiddleware.ts 64.28% <64.28%> (ø)
bemuse/src/app/entities/MusicSearchText.ts 76.92% <76.92%> (ø)
bemuse/src/app/redux/ReduxState.ts 77.77% <77.77%> (ø)
bemuse/src/app/entities/MusicSelection.ts 80.00% <80.00%> (ø)
bemuse/src/app/redux/configureStore.ts 80.00% <80.00%> (ø)
bemuse/src/app/redux/collectionFetchMiddleware.ts 81.81% <81.81%> (ø)
bemuse/src/app/entities/LoadState.ts 88.23% <88.23%> (ø)
bemuse/src/app/entities/Collections.ts 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MikuroXina MikuroXina marked this pull request as ready for review December 30, 2022 15:11
@MikuroXina MikuroXina self-assigned this Dec 30, 2022
Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Many thanks for converting the custom Redux framework (createReducer) to use something more standardized like Redux Toolkit. This has put the codebase is a much better shape.

@dtinth dtinth merged commit 2997000 into bemusic:master Dec 31, 2022
@MikuroXina MikuroXina deleted the refactor/state-manage branch December 31, 2022 09:31
dtinth added a commit that referenced this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants