Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when chunk loading failed #809

Merged
merged 2 commits into from
Jan 2, 2023
Merged

Improve error message when chunk loading failed #809

merged 2 commits into from
Jan 2, 2023

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Jan 2, 2023

When a chunk fails to load, ask user to hard refresh.

Changelog

Improved the error message that appears when the game fails to boot up, prompting the user to try hard-refreshing (usually it fixes the problem).

@dtinth dtinth enabled auto-merge January 2, 2023 11:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2023

Codecov Report

Base: 86.76% // Head: 86.76% // No change to project coverage 👍

Coverage data is based on head (0efcd29) compared to base (2e35267).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #809   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files         175      175           
  Lines        5366     5366           
  Branches      325      325           
=======================================
  Hits         4656     4656           
  Misses        663      663           
  Partials       47       47           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dtinth dtinth merged commit 0c7fbd8 into master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants