Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all jsx into tsx #812

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Refactor all jsx into tsx #812

merged 2 commits into from
Jan 3, 2023

Conversation

MikuroXina
Copy link
Collaborator

Separated from #790. But there are some .js files which contains React JSX syntax yet.

@MikuroXina MikuroXina self-assigned this Jan 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Base: 86.46% // Head: 86.46% // No change to project coverage 👍

Coverage data is based on head (793cf77) compared to base (135eec7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #812   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         175      175           
  Lines        5378     5378           
  Branches      362      362           
=======================================
  Hits         4650     4650           
  Misses        678      678           
  Partials       50       50           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MikuroXina MikuroXina marked this pull request as ready for review January 3, 2023 10:46
@MikuroXina MikuroXina requested a review from dtinth January 3, 2023 10:46
Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks~

@dtinth dtinth merged commit 2bbcb1e into bemusic:master Jan 3, 2023
@MikuroXina MikuroXina deleted the refactor/tsx branch January 3, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants