Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game loader #94

Merged
merged 23 commits into from
Feb 19, 2015
Merged

Game loader #94

merged 23 commits into from
Feb 19, 2015

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Feb 14, 2015

Establish data structures for the game and create a loader to load everything that's needed to initialize the game.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.09% when pulling 85ad540 on game-data into df075be on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.1% when pulling d4b122b on game-data into df075be on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.1% when pulling d498f74 on game-data into df075be on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.1% when pulling fe0145c on game-data into df075be on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.13%) to 98.96% when pulling da71ae7 on game-data into df075be on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.13%) to 98.96% when pulling 55287dd on game-data into df075be on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.13%) to 98.96% when pulling fa0161c on game-data into df075be on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.13%) to 98.96% when pulling f500be2 on game-data into df075be on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.24%) to 97.85% when pulling e5bf0eb on game-data into df075be on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-22.63%) to 76.46% when pulling 0c1fa70 on game-data into df075be on master.

@dtinth
Copy link
Member Author

dtinth commented Feb 18, 2015

Don't merge, refactor first!

Problems and Ideas

export class LoadingContext {
constructor(task) {
if (task) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor this. Always take a Progress and always use it.

@dtinth
Copy link
Member Author

dtinth commented Feb 18, 2015

Maybe, write a progress helper too, which helps report progress based on common tasks:

  • Module loading
  • XMLHttpRequest
  • Promises (numbers)

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.69%) to 90.39% when pulling 3c3cdc9 on game-data into df075be on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.69%) to 90.39% when pulling dc22065 on game-data into df075be on master.

When tested on larger screen, the game stays at 1x.
With help from the "web-audio-test-api" project. Many thanks!
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.23%) to 98.86% when pulling db4bbd5 on game-data into df075be on master.

@dtinth dtinth changed the title Game data Game loader Feb 19, 2015
dtinth added a commit that referenced this pull request Feb 19, 2015
@dtinth dtinth merged commit 2da82bc into master Feb 19, 2015
@dtinth dtinth deleted the game-data branch February 27, 2015 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants