Fixed JSON-LD syntax and description tag #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey Ben, I didn't use this plugin since I'm loading my somatic stuff differently, but I grabbed everything from line 70 down and added it to a custom script which seems to work as intended.
After running my Nuxt site through Google’s URL inspector it caught a syntax error with the JSON-LD script tags. I think what's getting stringified was an array instead of just the value of the object, (I was seeing `["breadcrumbList","{BREADCRUMB_VALUES}"]` instead of just `"{BREADCRUMB_VALUES}"`. Line 120 should fix that, but maybe a sanity check might be good there, too.
Regarding the "description" meta tag, I noticed it wasn’t overriding the default one picked up in my HTML template, so adding a `hid` set to "description" should do the trick there.
|
hey will thanks for for the PR on this. All looks good at first glance and I'll have a proper review shortly. Cheers! |
ben-rogerson
approved these changes
Nov 1, 2020
|
4 months later... damn I'm shocking. Well, at least it's going in! |
|
The error i get when updating to v0.2.1:
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Ben, I didn't use this plugin since I'm loading my somatic stuff differently, but I grabbed everything from line 70 down and added it to a custom script which seems to work as intended.
After running my Nuxt site through Google’s URL inspector it caught a syntax error with the JSON-LD script tags. I think what's getting stringified was an array instead of just the value of the object, (I was seeing
["breadcrumbList","{BREADCRUMB_VALUES}"]instead of just"{BREADCRUMB_VALUES}". Line 120 should fix that, but maybe a sanity check might be good there, too.Regarding the "description" meta tag, I noticed it wasn’t overriding the default one picked up in my HTML template, so adding a
hidset to "description" should do the trick there.