Fix XSS described in Backes 2016 #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation-level Analysis of the JavaScript Helios Voting Client describes an XSS attack in the Helios booth
|
@benadida this is kind of security sensitive, can you please merge this PR? |
|
Update: this is not enough to prevent XSS: see https://stackoverflow.com/a/29186757/5431090 |
|
Update: it might not be vulnerable anymore, I can't seem to reproduce the issue described in the paper |
|
@redfast00 sorry for the long delay here, my sense is that there are no obvious XSS attacks on Helios anymore, but of course there may be some non-obvious ones, so please do feel free to send patches! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation-level Analysis of the JavaScript Helios Voting Client describes an XSS attack in the Helios booth. This PR fixes that. See #225. Note that this PR does not prevent the booth from getting external URLs, as that might be seen as a feature.
I also don't guarantee the security of the rest of this project, this PR just fixes one XSS.