Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address feedback, fix linter warnings and add CI workflow #36

Merged
merged 11 commits into from
Feb 22, 2024
Merged

Address feedback, fix linter warnings and add CI workflow #36

merged 11 commits into from
Feb 22, 2024

Conversation

virtualroot
Copy link
Contributor

@virtualroot virtualroot commented Feb 21, 2024

I have run these linters and fixed their warnings:

  • awesome-lint - The awesome list linter.
  • markdownlint-cli2 - A Markdown linter.
  • lychee - Finds broken URLs inside Markdown.

I added a GitHub workflow to run all the above linters on future pull requests.

I'm also addressing some feedback from sindresorhus/awesome#2895.

I hope these changes help with the awesome-list submission.

Marker style should be -

`npx awesome-lint README.md`
Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## React"]
Unordered list indentation [Expected: 2; Actual: 4]
Multiple consecutive blank lines [Expected: 1; Actual: 2]
@virtualroot virtualroot mentioned this pull request Feb 21, 2024
33 tasks
@virtualroot virtualroot marked this pull request as draft February 21, 2024 14:20
@virtualroot virtualroot changed the title Fix linter warnings and add CI workflow Address feedback, fix linter warnings and add CI workflow Feb 21, 2024
@virtualroot virtualroot marked this pull request as ready for review February 21, 2024 14:34
@benallfree
Copy link
Owner

@virtualroot Should I merge and ask for another review in the upstream PR?

README.md Outdated Show resolved Hide resolved
List item link and description must be separated with a dash
@virtualroot
Copy link
Contributor Author

@benallfree Let's give it a try! 🤞

@benallfree benallfree merged commit 75df786 into benallfree:main Feb 22, 2024
1 check passed
@benallfree benallfree mentioned this pull request Feb 22, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants