fix: #138

benawad · Aug 19, 2020 · 54bd159 · 54bd159
1 parent 85543f4
commit 54bd159
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 1 deletion.
diff --git a/src/index/generateTrees/buildGraph.ts b/src/index/generateTrees/buildGraph.ts
@@ -7,7 +7,7 @@ import { findImports } from "../shared/findImports";
 import { findSharedParent } from "./shared/findSharedParent";
 
 const isFilePathIgnored = (filePath: string) => {
-  const ignoreList = [/^\.git/];
+  const ignoreList = [/^\.git|node_modules/];
 
   return ignoreList.some(re => re.test(filePath));
 };

diff --git a/tests/__snapshots__/end-to-end.test.ts.snap b/tests/__snapshots__/end-to-end.test.ts.snap
@@ -437,6 +437,26 @@ exports[`end-to-end --avoid-single-file globals: globals/src/index.js 1`] = `
 "
 `;
 
+exports[`end-to-end --avoid-single-file ignore-node-modules 1`] = `
+"ignore-node-modules
+├── file2.js
+├── index.js
+└── node_modules
+    ├── add.js
+    └── subtract.js"
+`;
+
+exports[`end-to-end --avoid-single-file ignore-node-modules: ignore-node-modules/file2.js 1`] = `""`;
+
+exports[`end-to-end --avoid-single-file ignore-node-modules: ignore-node-modules/index.js 1`] = `"require('./file2')"`;
+
+exports[`end-to-end --avoid-single-file ignore-node-modules: ignore-node-modules/node_modules/add.js 1`] = `
+"require('./subtract')
+"
+`;
+
+exports[`end-to-end --avoid-single-file ignore-node-modules: ignore-node-modules/node_modules/subtract.js 1`] = `""`;
+
 exports[`end-to-end --avoid-single-file index-cycle 1`] = `
 "index-cycle
 ├── index
@@ -1075,6 +1095,27 @@ export const five = 5;
 "
 `;
 
+exports[`end-to-end ignore-node-modules 1`] = `
+"ignore-node-modules
+├── index
+│   └── file2.js
+├── index.js
+└── node_modules
+    ├── add.js
+    └── subtract.js"
+`;
+
+exports[`end-to-end ignore-node-modules: ignore-node-modules/index.js 1`] = `"require('./index/file2')"`;
+
+exports[`end-to-end ignore-node-modules: ignore-node-modules/index/file2.js 1`] = `""`;
+
+exports[`end-to-end ignore-node-modules: ignore-node-modules/node_modules/add.js 1`] = `
+"require('./subtract')
+"
+`;
+
+exports[`end-to-end ignore-node-modules: ignore-node-modules/node_modules/subtract.js 1`] = `""`;
+
 exports[`end-to-end index-cycle 1`] = `
 "index-cycle
 ├── index

diff --git a/tests/fixtures/ignore-node-modules/file2.js b/tests/fixtures/ignore-node-modules/file2.js
diff --git a/tests/fixtures/ignore-node-modules/index.js b/tests/fixtures/ignore-node-modules/index.js
@@ -0,0 +1 @@
+require('./file2')