Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Added 38 Twitch emotes #1857

Closed
wants to merge 16 commits into from
Closed

🔥 Added 38 Twitch emotes #1857

wants to merge 16 commits into from

Conversation

asxlvm
Copy link
Contributor

@asxlvm asxlvm commented Apr 6, 2021

Hello,
I think I'm speaking for every Twitch fan of the community, we needed some emotes that were missing, I added 38 new emojis visible here;
PepeClown, Kappa, KEKR, peepoStare, ComfWee, ZULUL, SadgeJuice, SQUADW, peepoSQUAD, peepoWeird, NOOO, Susge, Weirdge, PepeMods, BlackU, peepoChrist, Madge, PagMan, Jebaited, 3Head, 4House, peepoHard, PepePains, 4Heed, AYAYAY, KKool, TriDance, MrCool, MrUncool, SadgeJam, catPOP, PartyKirby, RainbowPls, BoneDance, Dcolon, 1Head, KomodoHype

These are great additions to the app and I'd be glad if my pull request gets merged, thanks.
Asylum

PepeClown, Kappa, KEKR, peepoStare, ComfWee, ZULUL, SadgeJuice, SQUADW, peepoSQUAD, peepoWeird, NOOO, Susge, Weirdge, PepeMods, BlackU, peepoChrist, Madge, PagMan, Jebaited, 3Head, 4House, peepoHard, PepePains, 4Heed, AYAYAY, KKool, TriDance
PepeClown, Kappa, KEKR, peepoStare, ComfWee, ZULUL, SadgeJuice, SQUADW, peepoSQUAD, peepoWeird, NOOO, Susge, Weirdge, PepeMods, BlackU, peepoChrist, Madge, PagMan, Jebaited, 3Head, 4House, peepoHard, PepePains, 4Heed, AYAYAY, KKool, TriDance
@vercel
Copy link

vercel bot commented Apr 6, 2021

@asxlvm is attempting to deploy a commit to a Personal Account owned by @benawad on Vercel.

@benawad first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dogehouse – ./kibbeh

🔍 Inspect: https://vercel.com/benawad/dogehouse/Di4R1tReaSyQjAb7UQXJh5QbYjZ3
✅ Preview: Canceled

[Deployment for c8941c9 canceled]

@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 21:37 Inactive
@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 22:27 Inactive
@asxlvm asxlvm closed this Apr 6, 2021
@asxlvm asxlvm reopened this Apr 6, 2021
@asxlvm
Copy link
Contributor Author

asxlvm commented Apr 6, 2021

Accidentally closed it, thought it wouldn't add the MrCool and MrUncool there.

@asxlvm asxlvm changed the title 🔥 Added 28 Twitch emotes 🔥 Added 30 Twitch emotes Apr 6, 2021
@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 22:33 Inactive
@iamanalt
Copy link
Contributor

iamanalt commented Apr 6, 2021

This is a wonderful contribution. Approved!

@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 22:59 Inactive
@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 23:00 Inactive
@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 23:00 Inactive
@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 23:02 Inactive
@asxlvm asxlvm changed the title 🔥 Added 30 Twitch emotes 🔥 Added 31 Twitch emotes Apr 6, 2021
catPOP, RainbowPls, BoneDance, PartyKirby
@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 23:20 Inactive
catPOP, BoneDance, RainbowPls, PartyKirby
@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 23:23 Inactive
@asxlvm asxlvm changed the title 🔥 Added 31 Twitch emotes 🔥 Added 35 Twitch emotes Apr 6, 2021
@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 23:30 Inactive
@asxlvm asxlvm changed the title 🔥 Added 36 Twitch emotes 🔥 Added 35 Twitch emotes Apr 6, 2021
@asxlvm asxlvm changed the title 🔥 Added 35 Twitch emotes 🔥 Added 36 Twitch emotes Apr 6, 2021
@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 23:53 Inactive
@vercel vercel bot temporarily deployed to Preview – dogehouse April 6, 2021 23:54 Inactive
@asxlvm asxlvm changed the title 🔥 Added 36 Twitch emotes 🔥 Added 37 Twitch emotes Apr 6, 2021
@vercel vercel bot temporarily deployed to Preview – dogehouse April 7, 2021 00:23 Inactive
@vercel vercel bot temporarily deployed to Preview – dogehouse April 7, 2021 00:24 Inactive
@asxlvm asxlvm changed the title 🔥 Added 37 Twitch emotes 🔥 Added 38 Twitch emotes Apr 7, 2021
@benawad
Copy link
Owner

benawad commented Apr 7, 2021

We are capping the # of emotes to what we currently have, you need to remove 38 if you want to add 38.

@theCow61 what does he need to make lowercase?

@theCow61
Copy link
Contributor

theCow61 commented Apr 7, 2021

@benawad the json name and short name need to be lower case.

Also we could use git lfs for the emote assets if the git repo is getting to heavy because of all the images and gifs.

@BronzW
Copy link
Contributor

BronzW commented Apr 7, 2021

I'm not sure the Twitch emotes (for example Kappa) would be allowed in commercial use such as DogeHouse as plenty of sources, including Twitch, state that using Twitch Brand Assets would be against their policy and that their Assets (including emotes) are under trademark. ### Please note that I don't have any legal experience and this is just from what I've read and I might be completely wrong.

Without express permission, we do not allow use of emotes. Twitch and/or third parties own rights such as copyrights, trademarks, and/or rights of publicity in emotes on Twitch. Please note that in addition to us, the use of an emote may require permission from such third parties.

Don’t incorporate Twitch’s Brand Assets, or variants, in domain names, social media accounts, corporate names, app names, or as a part of any on-line or in person event (including community events or meet-ups), unless we have given express permission

Don’t combine Twitch Brand Assets as part of a name of a product or service.

Don’t use Twitch Brand Assets in a way that suggests an affiliation, partnership, sponsorship or endorsement by or with Twitch.

Don’t include Twitch Brand Assets in editorial content that suggests it’s been authored by, or represents the views or opinions of, Twitch or any Twitch personnel or affiliate.

Don’t present Twitch Brand Assets in a manner that is misleading, defamatory, libelous, obscene, infringing or otherwise in a manner that violates the spirit of Twitch’s Community Guidelines.

Don’t use Twitch Brand Assets on material that infringes the trademark, copyright or any other rights of any third party.

So we are allowed to use BetterTTV emotes. Twitch's own emotes such as Kappa, 4Head, NotLikeThis or LULW would not be allowed on DogeHouse without Twitch's permission so knowing that in the future might be pretty good.

https://www.twitch.tv/p/sv-se/legal/trademark/#general-usage-guidelines

https://www.twitch.tv/p/sv-se/legal/trademark/#emotes

@asxlvm
Copy link
Contributor Author

asxlvm commented Apr 7, 2021

Okay so what would I need to do?
Rename shortnames to lowercase
And by the way, Kappa is the emote of a Twitch staff from when Twitch was owned by Justin.tv so I don't think they have Copyright for that,but okay, I'll remove it Sadge
Aaand, why couldn't we host the emote CDN elsewhere so we can have more emotes? Github, etc.

@asxlvm
Copy link
Contributor Author

asxlvm commented Apr 7, 2021

And 4Head is a FrankerFaceZ emote, so I'll not remove it.

@asxlvm
Copy link
Contributor Author

asxlvm commented Apr 7, 2021

Aaaand, PogChamp is a Twitch emote kek

@amitojsingh366
Copy link
Contributor

yea, we aren't accepting more emotes as of rn...

@amitojsingh366
Copy link
Contributor

amitojsingh366 commented Apr 7, 2021

ok i just read @benawad 's comment so ill reopen this and it seems you didn't understand what he and the others meant. below is an explanation:

  • all the name and short_names keys in json should be lowercase (see comment below for example)
  • if you add 38 emotes you will have to remove 38 emotes. basically in the end the total no. of emotes should be less than or equal to 100
  • also there's some legality which i have no idea about

@amitojsingh366 amitojsingh366 reopened this Apr 7, 2021
@@ -1,6 +1,228 @@
import { EmojiData } from "emoji-mart";

export const customEmojis = [
{
name: "KomodoHype",
short_names: ["KomodoPog"],
Copy link
Contributor

@amitojsingh366 amitojsingh366 Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asxlvm these are the keys. so in this case you can just change
KomodoHype to komodohype and KomodoPog to komodopog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see

@theCow61
Copy link
Contributor

theCow61 commented Apr 7, 2021

If you have a lot of emotes you need to lower case, I would recommend making a quick script that takes the json, deserializes it, lowercases the name and short_name, and then serializes it.

Might make a script that does this so people contributing emotes can just run this when after editing the json.

@jobveldhuis
Copy link
Contributor

The Twitch legal trademark notice clearly states that the use of Twitch emotes outside of Twitch is forbidden, unless receiving express permission. I would highly advise against merging this pull request, in any form.

@asxlvm
Copy link
Contributor Author

asxlvm commented Apr 10, 2021

Okay and? We have PogChamp which is a Twitch emote, and then, how is Discord for ex. not sued as they have no control of use of their CDN, get it?

@amitojsingh366
Copy link
Contributor

Okay and? We have PogChamp which is a Twitch emote, and then, how is Discord for ex. not sued as they have no control of use of their CDN, get it?

but dogehouse does have control over their content. there aren't any custom emotes really. we have to approve all of them and then it goes to the dogehouse repo (which we have full control over). so if what @jobveldhuis said is true then we might get sued. anyway @benawad what do you think abt this?

@benawad
Copy link
Owner

benawad commented Apr 11, 2021

Instead of using twitch emotes, I am going to pay people to make doge themed version of every twitch emote

I don't want any legal problems

@benawad benawad closed this Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants