-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Added 38 Twitch emotes #1857
🔥 Added 38 Twitch emotes #1857
Conversation
PepeClown, Kappa, KEKR, peepoStare, ComfWee, ZULUL, SadgeJuice, SQUADW, peepoSQUAD, peepoWeird, NOOO, Susge, Weirdge, PepeMods, BlackU, peepoChrist, Madge, PagMan, Jebaited, 3Head, 4House, peepoHard, PepePains, 4Heed, AYAYAY, KKool, TriDance
PepeClown, Kappa, KEKR, peepoStare, ComfWee, ZULUL, SadgeJuice, SQUADW, peepoSQUAD, peepoWeird, NOOO, Susge, Weirdge, PepeMods, BlackU, peepoChrist, Madge, PagMan, Jebaited, 3Head, 4House, peepoHard, PepePains, 4Heed, AYAYAY, KKool, TriDance
@asxlvm is attempting to deploy a commit to a Personal Account owned by @benawad on Vercel. @benawad first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). dogehouse – ./kibbeh🔍 Inspect: https://vercel.com/benawad/dogehouse/Di4R1tReaSyQjAb7UQXJh5QbYjZ3 [Deployment for c8941c9 canceled] |
Accidentally closed it, thought it wouldn't add the MrCool and MrUncool there. |
This is a wonderful contribution. Approved! |
catPOP, RainbowPls, BoneDance, PartyKirby
catPOP, BoneDance, RainbowPls, PartyKirby
We are capping the # of emotes to what we currently have, you need to remove 38 if you want to add 38. @theCow61 what does he need to make lowercase? |
I'm not sure the Twitch emotes (for example
So we are allowed to use BetterTTV emotes. Twitch's own emotes such as Kappa, 4Head, NotLikeThis or LULW would not be allowed on DogeHouse without Twitch's permission so knowing that in the future might be pretty good. https://www.twitch.tv/p/sv-se/legal/trademark/#general-usage-guidelines |
Okay so what would I need to do? |
And 4Head is a FrankerFaceZ emote, so I'll not remove it. |
Aaaand, PogChamp is a Twitch emote kek |
yea, we aren't accepting more emotes as of rn... |
ok i just read @benawad 's comment so ill reopen this and it seems you didn't understand what he and the others meant. below is an explanation:
|
@@ -1,6 +1,228 @@ | |||
import { EmojiData } from "emoji-mart"; | |||
|
|||
export const customEmojis = [ | |||
{ | |||
name: "KomodoHype", | |||
short_names: ["KomodoPog"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asxlvm these are the keys. so in this case you can just change
KomodoHype
to komodohype
and KomodoPog
to komodopog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I see
If you have a lot of emotes you need to lower case, I would recommend making a quick script that takes the json, deserializes it, lowercases the name and short_name, and then serializes it. Might make a script that does this so people contributing emotes can just run this when after editing the json. |
The Twitch legal trademark notice clearly states that the use of Twitch emotes outside of Twitch is forbidden, unless receiving express permission. I would highly advise against merging this pull request, in any form. |
Okay and? We have PogChamp which is a Twitch emote, and then, how is Discord for ex. not sued as they have no control of use of their CDN, get it? |
but dogehouse does have control over their content. there aren't any custom emotes really. we have to approve all of them and then it goes to the dogehouse repo (which we have full control over). so if what @jobveldhuis said is true then we might get sued. anyway @benawad what do you think abt this? |
Instead of using twitch emotes, I am going to pay people to make doge themed version of every twitch emote I don't want any legal problems |
Hello,
I think I'm speaking for every Twitch fan of the community, we needed some emotes that were missing, I added 38 new emojis visible here;
PepeClown, Kappa, KEKR, peepoStare, ComfWee, ZULUL, SadgeJuice, SQUADW, peepoSQUAD, peepoWeird, NOOO, Susge, Weirdge, PepeMods, BlackU, peepoChrist, Madge, PagMan, Jebaited, 3Head, 4House, peepoHard, PepePains, 4Heed, AYAYAY, KKool, TriDance, MrCool, MrUncool, SadgeJam, catPOP, PartyKirby, RainbowPls, BoneDance, Dcolon, 1Head, KomodoHype
These are great additions to the app and I'd be glad if my pull request gets merged, thanks.
Asylum