Skip to content
This repository has been archived by the owner on Nov 24, 2019. It is now read-only.

When API >= 26 you have to use NotificationChannel #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michielvaneerd
Copy link
Contributor

When API >= 26 you have to use NotificationChannel otherwise notifications don't work anymore. This pull request adds NotificationChannel support and makes notifications work again. Other small changes:

  • Small improvement with repeated notifications
  • Update documentation

@adampax
Copy link
Contributor

adampax commented Sep 17, 2018

I think people are going to run into this more now that Google is starting to require min api 26. Previous version of the module will fail silently.

@AppWerft
Copy link

Yes I have experiences. I have build an other module with PN, Next days I will look into.

@AppWerft
Copy link

Maybe TaskScheduler is a better idea for starting processes later.
http://www.vogella.com/tutorials/AndroidTaskScheduling/article.html

@Astrovic
Copy link

Thanks @michielvaneerd your PR works fine, but I've an issue: when I click on the notification icon, the app shows this alert dialog:

Restart Required
An application restart is required

CONTINUE

and the app don't restart anymore

@michielvaneerd
Copy link
Contributor Author

@Astrovic For me it's working. If you can share the code for a runnable example I can have a look.

@Astrovic
Copy link

@michielvaneerd I solved by adding this property on tiapp.xml:

<property name="ti.android.bug2373.finishfalseroot" type="bool">true</property>

@chmiiller
Copy link

Is someone merging this?

@Astrovic
Copy link

https://github.com/michielvaneerd/benCoding.AlarmManager/blob/master/dist/bencoding.alarmmanager-android-2.0.0.zip

@chmiiller
Copy link

thanks for sharing @Astrovic and @michielvaneerd , maybe someone could have the official github repo and make it the upstream version later?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants