Stringify S3 delete errors #555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error doesn't necessary have all fields and we can end up dereferencing a nil pointer causing a panic.
hifi
added a commit
to beeper/litestream
that referenced
this pull request
Jan 5, 2024
The SDK provides helper functions when you want an empty value if the actual one is nil so we can just wrap all of them to avoid getting bit. Fixes benbjohnson#556 Replaces benbjohnson#555 Also fixes another panic when getting a delete error without key.
|
Superseded by #557 |
hifi
added a commit
to beeper/litestream
that referenced
this pull request
Jan 5, 2024
The SDK provides helper functions when you want an empty value if the actual one is nil so we can just wrap all of them to avoid getting bit. Fixes benbjohnson#556 Replaces benbjohnson#555 Also fixes another panic when getting a delete error without key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error doesn't necessary have all fields and we can end up dereferencing a nil pointer causing a panic.
An example of such error after this commit:
In this instance, B2 is having issues but doesn't provide a Key in the error which the code assumes to always exist. Since the struct has a
String()method the safe solution and is only used in errors so the formatting isn't critical.