Never directly dereference AWS SDK returned pointers #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hifi
force-pushed
the
fix/s3-unsafe-use-of-content-length
branch
from
122fbbd
to
11da7b9
Compare
hifi
changed the title
hifi
changed the title
The SDK provides helper functions when you want an empty value if the actual one is nil so we can just wrap all of them to avoid getting bit. Fixes benbjohnson#556 Replaces benbjohnson#555 Also fixes another panic when getting a delete error without key.
hifi
force-pushed
the
fix/s3-unsafe-use-of-content-length
branch
from
11da7b9
to
9096d3e
Compare
This was referenced Jan 5, 2024
benbjohnson
approved these changes
Jan 6, 2024
|
@hifi / @benbjohnson - Will this be included in a new Release? :) Thanks for all the work on Litestream Related to: #589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently AWS or some other provider doesn't set the Content-Length header for all get object requests and we assume it can never be nil. Since it's only used for metrics we can allow them to be incorrect in those cases.
Proper fix would be to wrap the returned
io.ReadCloserwith one that will count the bytes read but that feels a bit much for some edge cases.Fixes #556
Also replaced #555 with this by wrapping all possibly unsafe uses of AWS SDK returned pointers.