Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akoutmos adding table support #377

Merged
merged 11 commits into from
Dec 23, 2022
Merged

Akoutmos adding table support #377

merged 11 commits into from
Dec 23, 2022

Conversation

PragTob
Copy link
Member

@PragTob PragTob commented Dec 22, 2022

Follow up to #369

  • Some naming/code changes
  • Only render out data from measurements that have actually been taken, seems like a good idea
    • add some functions to support operating over all the data/just the used data more smoothly
  • change order slightly so we preserve run time, memory, reductions

@PragTob
Copy link
Member Author

PragTob commented Dec 22, 2022

So, with benchee's very optimistic support goals dating back to elixir 1.6 we're clashing with table that used __STACKTRACE__ introduced in 1.7.

So options are:

  • spin out as a separate package after all
  • fiddle with CI to not attempt to install table on unsupported versions

@PragTob PragTob force-pushed the akoutmos-adding-table-support branch from cc19a38 to 556de81 Compare December 23, 2022 10:33
@PragTob PragTob merged commit b839502 into main Dec 23, 2022
@PragTob PragTob deleted the akoutmos-adding-table-support branch December 23, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants