Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API change stop_strategy to stopping_strategy #274

Merged
merged 9 commits into from
Dec 20, 2021
Merged

API change stop_strategy to stopping_strategy #274

merged 9 commits into from
Dec 20, 2021

Conversation

bmalezieux
Copy link
Contributor

@bmalezieux bmalezieux commented Dec 17, 2021 •
edited
Loading

Issue #273

tomMoral
tomMoral approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! :) just a few nitpicks.

benchopt/runner.py Outdated Show resolved Hide resolved
doc/whats_new.rst Outdated Show resolved Hide resolved
doc/how.rst Outdated Show resolved Hide resolved
bmalezieux and others added 2 commits December 17, 2021 16:30
@bmalezieux @tomMoral
Update doc/how.rst
c83960c 
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
@bmalezieux
API: adding property in BaseSolver instead
ede885d
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #274 (26aba1d) into main (08f82b0) will decrease coverage by 1.85%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   62.66%   60.80%   -1.86%     
==========================================
  Files          41       41              
  Lines        2100     2202     +102     
  Branches      372      401      +29     
==========================================
+ Hits         1316     1339      +23     
- Misses        688      766      +78     
- Partials       96       97       +1

tomMoral
tomMoral approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nitpicks :)
But then we are good to go.

benchopt/base.py Outdated Show resolved Hide resolved
benchopt/base.py Outdated Show resolved Hide resolved
benchopt/base.py Outdated Show resolved Hide resolved
benchopt/base.py Outdated Show resolved Hide resolved
benchopt/runner.py Outdated Show resolved Hide resolved
benchopt/runner.py Outdated Show resolved Hide resolved
benchopt/stopping_criterion.py Outdated Show resolved Hide resolved
tomMoral
tomMoral reviewed Dec 18, 2021
View reviewed changes
benchopt/runner.py Outdated Show resolved Hide resolved
tomMoral
tomMoral approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx @bmalezieux

benchopt/base.py Outdated Show resolved Hide resolved
@tomMoral tomMoral merged commit 1260dbf into benchopt:main Dec 20, 2021
This was referenced Dec 20, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomMoral tomMoral tomMoral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmalezieux @codecov-commenter @tomMoral