Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling problem: no down arrow is shown when change sorting order #97

Closed
algbeta opened this issue Feb 8, 2017 · 4 comments
Closed
Labels

Comments

@algbeta
Copy link

algbeta commented Feb 8, 2017

Hi!

This problem can be reproduced on demo site too
http://react-redux-grid.herokuapp.com/Simple

when you change column sorting to asc sorting arrow in the column header disappears however i can see it among styles
.react-grid-header th .react-grid-sort-handle.react-grid-asc::before
but it's not being caught

Hope it helps!
Thank you!

@bencripps bencripps added the bug label Feb 8, 2017
@bencripps
Copy link
Owner

Thanks for posting this issue -- this was the result of a style refactor done a few weeks ago. Sorry about that.

The bug has been fixed, you can clone down master from github and verify the changes work for you as well. Make sure to run npm run dist to ensure you've built the latest code.

Let me know if this resolves the issue, and I will create a new release.

bencripps added a commit that referenced this issue Feb 8, 2017
@algbeta
Copy link
Author

algbeta commented Feb 9, 2017

Hi,
Looks like it's fixed!
Thanks!

@bencripps
Copy link
Owner

Awesome, this will be published with this week's release!

@bencripps
Copy link
Owner

Published in 5.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants