Changes are made to insert a new row into a specific location of grid by passing rowIndex parameter to addNewRow(ADD_NEW_ROW) action. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passing rowIndex parameter to addNewRow(ADD_NEW_ROW) action.
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 81.33% 81.34% +<.01%
==========================================
Files 111 111
Lines 4490 4492 +2
==========================================
+ Hits 3652 3654 +2
Misses 838 838
Continue to review full report at Codecov.
|
bencripps
requested changes
Feb 27, 2017
| @@ -160,7 +160,8 @@ export const addNewRow = (state, { rowId, stateKey }) => { | |||
| data = new List(); | |||
| } | |||
|
|
|||
| const newData = data.unshift(newRow); | |||
| rowIndex = rowIndex===undefined?0:rowIndex; | |||
There was a problem hiding this comment.
rowIndex = rowIndex === undefined
? 0
: rowIndex;There was a problem hiding this comment.
Greate! Thanks.
There was a problem hiding this comment.
No problem, once you push the change, I will merge!
|
I have push the coding style change for "? :" operator . Do I need to create a new pull request or can you merge from this pull request on my "addnewrowatpos" branch? |
bencripps
approved these changes
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have test it to add a new row into a specific location and confirmed that it works. However it fails some testing on 'npm t'. Please take a look.