Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added will-change: transform to prevent repaints on scroll #159

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

Vanderslice
Copy link
Contributor

  • Added will-change: transform to table-container to prevent repaints when scrolling the grid in Chrome, Firefox, and Opera. This change causes slightly more memory usage but provides smoother scrolling with a large number of records; was maintaining 60fps with 2,000 records.

  • We could look at adding something like "transform: translateZ(0)" to help with Safari but it's not really a proper usage

  • Fixed an existing linting error

@codecov-io
Copy link

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   76.83%   76.83%           
=======================================
  Files         112      112           
  Lines        4558     4558           
  Branches      277      277           
=======================================
  Hits         3502     3502           
  Misses        846      846           
  Partials      210      210
Impacted Files Coverage Δ
src/util/stateGetter.js 89.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3008944...03ddc3c. Read the comment docs.

@bencripps bencripps merged commit dd3bffc into bencripps:master Apr 25, 2017
@bencripps
Copy link
Owner

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants