Add guard for global.navigation in Column.jsx #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the Column.jsx is making use of global.navigator without any guard, you cannot shallow render any component that imports react-redux-grid.
This means that you have to mock out any imports of react-redux-grid to test the components that wrap them.
Simply adding a check for navigator allows the parent component that imports react-redux-grid to be shallowly rendered and tested.
Another possible solution would be to run the check each time Column.render is called but I didn't go this route to preserve the current performance characteristic of the current isChrome check.