IE11 fix for regression in 3.1.7 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After debugging this for a while, it seems as if you could just use the value from the input instead of the $viewValue. IE doesn't update the $viewValue like the other browsers. Tested in IE11, Chrome and Firefox.
|
Thanks! I don't want to invest the time to do automated cross-browser testing with this project. Normally I'd insist on failing tests but I've struggled to test these selection changes in Phantom. So fingers crossed I guess, appreciate the manual testing. |
|
No problem. I'm willing to help with any issues that might arise from my PR or any cross-browser issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue outlined in #169.
After debugging this for a while, it seems as if you could just use the value from the input instead of the $viewValue. IE doesn't update the $viewValue like the other browsers. Tested in IE11, Chrome and Firefox.
Unfortunately, I am unable to run the tests for this project. Running
npm installresults in an error relating to a path issue installing zuul. I'll try to use my Mac to run the tests instead of Windows 10.