Support for mongoid 7.0.0 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Association reflections no longer have a `.macro`
|
I'm afraid I can't make the spec pass with mongoid 4 on travis. Locally it runs green though. |
tomasc
reviewed
May 3, 2018
mongoid-tree.gemspec
Outdated
| @@ -12,7 +12,8 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.files = Dir.glob('{lib,spec}/**/*') + %w(LICENSE README.md Rakefile Gemfile .rspec) | |||
|
|
|||
| s.add_runtime_dependency('mongoid', ['< 7.0', '>= 4.0']) | |||
| s.add_runtime_dependency('mongoid', ['<= 7.0', '>= 4.0']) | |||
There was a problem hiding this comment.
We will want to change this to
s.add_runtime_dependency('mongoid', ['< 8', '>= 4.0'])
in order to allow minor versions of Mongoid 7
|
Hi @asgerb! Thanks so much for this fantastic pull request. I can confirm that the specs run locally. Not sure what's up with the CI build there. |
|
@benedikt if we could have a new version of the gem released, it would be awesome! thank you! |
|
@tomasc v2.1.1 is on RubyGems now :) |
|
@benedikt thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
mongoid 7.0.0did not require any changes to the code, but a small change to thetree_spec.rbwas needed.In
mongoid 7.0.0Node.reflect_on_associationno longer has the.macro. So instead of testing against.macroI tested the type of the reflection. In order to just do this on 7 I added themongoid-compabilititygem as a development dependency.I also updated
Gemfileand.travis.ymlto make travis test against multiple mongoid versions (4..7).