Merge current branch with staging #42
Conversation
- Change password form implemented to use old passwords - Readme refactored and changed - Codeclimate yml introduced - Test refactored to implement current changes with the program
- Read me updated in respect to feedback - Google authentication installed and working with sign in route - Google auth removed from sign up from client side - Read me updated with a link to the Project FAQs - Notifier reducers implemented
- Implemented spacing between Jsdoc statements - Implemented reducer for categories to help refactor the bookReducer
- Fix for loading of userList on heroku - Shortened Google Auth for usernames
- Removed old files inappropriately named
…-be-to-sign-in-with-google-authentication Feature/153569580/users should be to sign in with google authentication
| DELETE_CATEGORY_SUCCESS, | ||
| FETCH_CATEGORIES_SUCCESS, | ||
| FETCH_CATEGORIES_FAILURE, | ||
| } from '../actions/actionType'; |
There was a problem hiding this comment.
Missing file extension for "../actions/actionType" import/extensions
| GET_USER_FAILURE, | ||
| PASSWORD_CHANGED_SUCCESS, | ||
| PASSWORD_CHANGED_FAILURE | ||
| } from '../actions/actionType'; |
There was a problem hiding this comment.
Missing file extension for "../actions/actionType" import/extensions
| import { | ||
| GET_NOTIFICATIONS_FAILURE, | ||
| GET_NOTIFICATIONS_SUCCESS | ||
| } from '../actions/actionType'; |
There was a problem hiding this comment.
Missing file extension for "../actions/actionType" import/extensions
| @@ -1,7 +1,7 @@ | |||
| import { | |||
| UPLOAD_TO_CLOUD_IMAGE_SUCCESS, | |||
| UPLOAD_TO_CLOUD_IMAGE_FAILURE | |||
| } from '../actions/actiontype'; | |||
| } from '../actions/actionType'; | |||
There was a problem hiding this comment.
Missing file extension for "../actions/actionType" import/extensions
| @@ -4,8 +4,15 @@ import { reducer as notifReducer } from 'redux-notifications'; | |||
| import userReducer from './userReducers'; | |||
| import bookReducer from './bookReducers'; | |||
| import imageReducer from './imageReducers'; | |||
| import notifierReducer from './notifierReducers'; | |||
| import categoryReducer from './categoryReducers'; | |||
There was a problem hiding this comment.
Missing file extension for "./categoryReducers" import/extensions
| @@ -0,0 +1,17 @@ | |||
| import React from 'react'; | |||
| import { Row } from 'react-materialize'; | |||
There was a problem hiding this comment.
Missing file extension for "react-materialize" import/extensions
| @@ -0,0 +1,17 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Missing file extension for "react" import/extensions
| )) : null; | ||
| const rows = props.books && props.books.length ? | ||
| props.books.map((book, index) => ( | ||
| <tr key={index}> |
There was a problem hiding this comment.
Do not use Array index in keys react/no-array-index-key
| @@ -2,24 +2,33 @@ import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import moment from 'moment'; | |||
| import { Row } from 'react-materialize'; | |||
| import MessageforNoBooksHistory from '../messages/dashboardMessages/MessageforNoBooksHistory.jsx'; | |||
| import MessageforNoBooksHistory | |||
| from '../messages/dashboardMessages/MessageforNoBooksHistory.jsx'; | |||
There was a problem hiding this comment.
Unexpected use of file extension "jsx" for "../messages/dashboardMessages/MessageforNoBooksHistory.jsx" import/extensions
| >Edit | ||
| </Button> | ||
| <Button | ||
| onClick={() => this.handleDelete(this.props.book.id)} |
There was a problem hiding this comment.
'book.id' is missing in props validation react/prop-types
|
Changes Unknown when pulling 93642cd on development into ** on staging**. |
Merge pull request #41 from benfluleck/feature/153569580/users-should-be-to-sign-in-with-google-authentication
Feature/153569580/users should be to sign in with google authentication