-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/153569580/users should be to sign in with google authentication #41
Feature/153569580/users should be to sign in with google authentication #41
Conversation
- Change password form implemented to use old passwords - Readme refactored and changed - Codeclimate yml introduced - Test refactored to implement current changes with the program
- Read me updated in respect to feedback - Google authentication installed and working with sign in route - Google auth removed from sign up from client side - Read me updated with a link to the Project FAQs - Notifier reducers implemented
- Implemented spacing between Jsdoc statements - Implemented reducer for categories to help refactor the bookReducer
- Fix for loading of userList on heroku - Shortened Google Auth for usernames
- Removed old files inappropriately named
} else { | ||
Materialize.toast('Please sign in again', 3000) | ||
Materialize.toast('Please sign in again', 3000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Materialize' is not defined no-undef
this | ||
.props | ||
.history | ||
.push('/login') | ||
.push('/login'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'history.push' is missing in props validation react/prop-types
import { connect } from 'react-redux'; | ||
import { signup } from '../../../actions/authenticate'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing file extension for "../../../actions/authenticate" import/extensions
import { LOAN_HISTORY_FAILURE, LOAN_HISTORY_SUCCESS } from './actiontype'; | ||
import { | ||
LOAN_HISTORY_FAILURE, | ||
LOAN_HISTORY_SUCCESS } from './actionType'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing file extension for "./actionType" import/extensions
@@ -5,23 +5,38 @@ import { showErrorNotification } from './notifications'; | |||
import { UPLOAD_TO_CLOUD_IMAGE_SUCCESS, | |||
UPLOAD_TO_CLOUD_IMAGE_FAILURE, | |||
CLOUDINARY_UPLOAD_PRESET, | |||
CLOUDINARY_UPLOAD_URL } from './actiontype'; | |||
CLOUDINARY_UPLOAD_URL } from './actionType'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing file extension for "./actionType" import/extensions
import nullvalidationMiddleware from '../controllers/middleware/nullValidation'; | ||
import decodeToken from '../controllers/middleware/authenticate'; | ||
import checkAdmin from '../controllers/middleware/checkAdmin'; | ||
import checkGoogleAuth from '../controllers/middleware/checkGoogleAuth'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing file extension for "../controllers/middleware/checkGoogleAuth" import/extensions
@@ -1,9 +1,11 @@ | |||
import express from 'express'; | |||
import controller from '../controllers'; | |||
import fieldValidationMiddleware from '../controllers/middleware/fieldValidations'; | |||
import fieldValidationMiddleware from | |||
'../controllers/middleware/fieldValidations'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing file extension for "../controllers/middleware/fieldValidations" import/extensions
isAdmin: req.body.isAdmin | ||
}).then((user) => { | ||
if (user) { | ||
res.status(201).send({ | ||
message: `${user.username} has been added, Please Login` | ||
message: `${user.username} has been added to the library,` + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 51 exceeds the maximum line length of 80 max-len
@@ -1,17 +1,23 @@ | |||
import models from '../models'; | |||
import paginationFunc from '../controllers/middleware/pagination'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing file extension for "../controllers/middleware/pagination" import/extensions
@@ -1,8 +1,8 @@ | |||
import { isLength, isAlpha, isNumeric, isEmpty, isAlphanumeric } from 'validator'; | |||
import { isLength, isAlpha, isNumeric, isAlphanumeric } from 'validator'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing file extension for "validator" import/extensions
Description
What does this PR do?
This PR merges the changes to the development branch and also publishing the changes to the web app on heroku
Screenshots (if appropriate):
Any background context you want to provide?
What are the relevant pivotal tracker stories?
https://www.pivotaltracker.com/story/show/153569580
https://www.pivotaltracker.com/story/show/153569722
https://www.pivotaltracker.com/story/show/153569550
https://www.pivotaltracker.com/story/show/153569503
https://www.pivotaltracker.com/story/show/153561900
Types of changes
Checklist: