Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct month abbrevs for June and July #24

Merged
merged 1 commit into from
Dec 16, 2013

Conversation

joetime
Copy link
Contributor

@joetime joetime commented Dec 16, 2013

was "june" now "jun"
was "july" now "jul"

was "june" now "jun"
was "july" now "july"
@kitten
Copy link
Contributor

kitten commented Dec 16, 2013

Actually these abbreviations are correct!
These sources claim the abbreviations to be "June" and "July", so not shortened at all.
http://www.library.yale.edu/cataloging/months.htm
http://library.princeton.edu/departments/tsd/katmandu/reference/months.html

But on the other hand this source confirms your abbreviation:
http://www.aresearchguide.com/monthdayabb.html

But still I'd prefer norms by Princeton and Yale University.

@joetime
Copy link
Contributor Author

joetime commented Dec 16, 2013

I guess it depends on what it's being used for.
It seemed like that array was being used for searching (or matching), in which case I would think the more general one would be best. Or both really, if we're searching for complete word matches.

On Dec 16, 2013, at 3:46 PM, Phil Plückthun notifications@github.com wrote:

Actually these abbreviations are correct!
These sources claim the abbreviations to be "June" and "July", so not shortened at all.
http://www.library.yale.edu/cataloging/months.htm
http://library.princeton.edu/departments/tsd/katmandu/reference/months.html

But on the other hand this source confirms your abbreviation:
http://www.aresearchguide.com/monthdayabb.html

But still I'd prefer norms by Princeton and Yale University.


Reply to this email directly or view it on GitHub.

@kitten
Copy link
Contributor

kitten commented Dec 16, 2013

I guess it doesn't hurt to just add these abbreviations and remove 'may' from the array. The names of the months are included in date.months anyway and the date.monthAbbrs array isn't used anwhere else. ;)

this.date.monthAbbrs = ['jan','feb','mar','apr','jun','jul','aug','sept','oct','nov','dec'];

@benhmoore
Copy link
Owner

@philplckthun @joetime good point, thanks for the edit!

benhmoore pushed a commit that referenced this pull request Dec 16, 2013
Correct month abbrevs for June and July
@benhmoore benhmoore merged commit 742dd34 into benhmoore:master Dec 16, 2013
@joetime
Copy link
Contributor Author

joetime commented Dec 16, 2013

Woohoo my first ever git commit!
Beers on me :)

@joetime joetime deleted the patch-1 branch December 17, 2013 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants