Skip to content
This repository has been archived by the owner on Dec 24, 2019. It is now read-only.

Commit

Permalink
Spec that deps should rescue UnmeetableDep and fail fast when it's ra…
Browse files Browse the repository at this point in the history
…ised during met? and meet.
  • Loading branch information
benhoskings committed Jan 10, 2011
1 parent ed52bf3 commit 69b85a2
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
12 changes: 12 additions & 0 deletions spec/babushka/dep_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,12 @@
).meet.should == false
@yield_counts['unmeetable'].should == @yield_counts_meet_run
end
it "should fail fast on explicitly unmeetable deps" do
make_counter_dep(
:name => 'explicitly unmeetable', :met? => L{ raise UnmeetableDep }
).meet.should == false
@yield_counts['explicitly unmeetable'].should == @yield_counts_met_run
end
it "should fail, run meet, and then succeed on unmet deps" do
make_counter_dep(
:name => 'unmet', :met? => L{ @yield_counts['unmet'][:met?] > 1 }
Expand All @@ -443,6 +449,12 @@
).meet.should == false
@yield_counts['unmet, #before fails'].should == @yield_counts_failed_at_before
end
it "should fail, not run meet, and fail again on unmet deps where meet raises UnmeetableDep" do
make_counter_dep(
:name => 'unmet, #before fails', :met? => L{ false }, :meet => L{ raise UnmeetableDep }
).meet.should == false
@yield_counts['unmet, #before fails'].should == @yield_counts_early_exit_meet_run
end
it "should fail, run meet, and then succeed on unmet deps where after fails" do
make_counter_dep(
:name => 'unmet, #after fails', :met? => L{ @yield_counts['unmet, #after fails'][:met?] > 1 }, :after => L{ false }
Expand Down
1 change: 1 addition & 0 deletions spec/babushka/dep_support.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ def setup_yield_counts
@yield_counts_meet_run = {:setup => 1, :met? => 2, :prepare => 1, :before => 1, :meet => 1, :after => 1}
@yield_counts_dep_failed = {:setup => 1}
@yield_counts_failed_meet_run = {:setup => 1, :met? => 2, :prepare => 1, :before => 1, :meet => 1, :after => 1}
@yield_counts_early_exit_meet_run = {:setup => 1, :met? => 1, :prepare => 1, :before => 1, :meet => 1}
@yield_counts_already_met = {:setup => 1, :met? => 1}
@yield_counts_failed_at_before = {:setup => 1, :met? => 2, :prepare => 1, :before => 1}
end
Expand Down

0 comments on commit 69b85a2

Please sign in to comment.