New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-render thumbnails when images change #6

Merged

benhowell merged 1 commit into benhowell:master from cust0dian-old:fix-no-render-on-props-change

Sep 10, 2016

Contributor

cust0dian-old commented Sep 10, 2016 •

edited

Loading

Currently only thumbnails are updated when images props changes, meaning re-render doesn't happen until window is resized:

If you think of a better fix than mine, here's the code I used to replicate this issue.


          Re-render thumbnails when images change

0216f8e

cust0dian-old mentioned this pull request

Make sure React knows that each image is a unique entity #7

Merged

benhowell merged commit c9f3561 into benhowell:master

Owner

benhowell commented Sep 10, 2016

Thanks cust0dian, nice pick up! Merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet