fix for testing autogenerated keys #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems that ResultSet#getObject doesn't reliably return an appropriate datatype when fetching auto-generated keys after an insert statement eg for Derby, even if the autogenerated column has type INT or BIGINT, a java.util.BigDecimal is still returned. The change works around this problem by using one of the ResultSet#get<X> methods to cast the result to the appropriate datatype, and adds tests for this problem.
benilovj
added a commit
that referenced
this pull request
Jul 5, 2013
fix for testing autogenerated keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems that
ResultSet#getObjectdoesn't reliably return an appropriatedatatype when fetching auto-generated keys after an insert statement
eg for Derby, even if the autogenerated column has type
INTorBIGINT,a
java.util.BigDecimalis still returned.The change works around this problem by using one of the
ResultSet#get<X>methods to cast the result to the appropriate datatype, and adds tests for
this problem.