Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate dbfit and fitnesse wikidocs #136

Merged
merged 7 commits into from
Jul 6, 2013

Conversation

javornikolov
Copy link
Contributor

This is related to #13

  • Make DbFit wiki docs auto-expandable by FitNesse (alongside the core FitNesse docs)
  • Remove -o option from startFitnesse shell scripts. This way bundled FitNesse docs will be expanded and also DbFit docs will be expanded too when using -d. It's still possible to override this by passing -o argument to shell scripts.
  • Modify DbFit wiki docs front page so that it includes reference to FitNesse core docs.

!-</div>-!
----
!3 DbFit is based on [[FitNesse][FitNesse.FitNesse]] framework.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the FitNesse framework

@benilovj
Copy link
Member

benilovj commented Jul 6, 2013

Apart from the comments, LGTM.

@benilovj
Copy link
Member

benilovj commented Jul 6, 2013

great, thanks for this, merging...

benilovj added a commit that referenced this pull request Jul 6, 2013
…kidocs

Integrate dbfit and fitnesse wikidocs
@benilovj benilovj merged commit 001eb4a into master Jul 6, 2013
@benilovj benilovj deleted the integrate-dbfit-and-fitnesse-wikidocs branch July 6, 2013 22:33
@benilovj
Copy link
Member

benilovj commented Jul 6, 2013

Oh, just thought of something, if we're unpacking docs by default, it might be useful to include a default .gitignore which will ignore:

  • FitNesseRoot/FitNesse
  • FitNesseRoot/DbFit
  • the errorlogs folder

what do you think?

@javornikolov
Copy link
Contributor Author

I'm not sure. In general .gitignore is something project specific.
Similar thing actually applies to some other special files/folders - e.g. testResults.

Maybe it's worth trying to put some notes about putting tests under version control - either directly or via some reference to existing ones (since it's pure FitNesse question).

@javornikolov
Copy link
Contributor Author

Another annoying file is properties - which contains FitNesse release date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants