Add support for inserting Oracle object types #172
Conversation
| @Override | ||
| protected void afterConnectionEstablished() throws SQLException { | ||
| super.afterConnectionEstablished(); | ||
| TypeAdapter.registerParseDelegate(java.sql.Struct.class, |
There was a problem hiding this comment.
Initially I tried to do this registration in the constructor but for some reason it failed: connection wasn't open while trying to parse (even when accessing it lazy via OracleEnvironment.getConnection).
|
Hmm, some leftovers here - since I rebased on old version of #171, need to be cleaned up. [FIXED] |
Add initial version of OracleObjectTypeParseDelegate
|
OK, looks good to me. Would it be worth adding a test or two for the Oracle spacial types mentioned in #169? |
|
Yes, I'll add one. (I wasn't sure if Spatial is included in Oracle Express edition but seems it is - at least some part of it). |
| create table persons(reg_id integer, member person_type); | ||
|
|
||
| -- A table with spatial objects | ||
| create table spatial_line(objectid integer, geometry sdo_geometry); |
There was a problem hiding this comment.
now, unless we reuse this in other places, I'd probably prefer to create (and drop) this within the test. This would make the test more explicit.
Same applies for person_type and persons.
There was a problem hiding this comment.
The issue with DDL like create, drop, etc. statements is that they're committing the transaction.
But the tests are quite small so perhaps won't be a huge trouble to break that single transaction guideline in this case.
There was a problem hiding this comment.
In any case, this is done in a lot of other tests, eg this one.
…ort-169 Add support for inserting Oracle object types
|
great work again, @javornikolov |
Address #169 - support inserting of Oracle Object Types.
(Merge this after #171)