Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go implementation goes into an infinite loop when calculating hash for 0.0 #42

Closed
maljub01 opened this issue Dec 4, 2017 · 0 comments
Closed

Go implementation goes into an infinite loop when calculating hash for 0.0 #42

maljub01 opened this issue Dec 4, 2017 · 0 comments

Comments

@maljub01
Copy link
Contributor

maljub01 commented Dec 4, 2017

The Go tests start failing (after timing out) when the following lines are added to common_json.test:

0.0
60101d8c9cb988411468e38909571f357daa67bff5a7b0a3f9ae295cd4aba33d

This is because an input of 0 to the floatNormalize function results in an infinite loop.
benlaurie added a commit that referenced this issue Feb 2, 2018
@benlaurie
Merge pull request #43 from maljub01/fix-42
c3fbb18 
Fix #42: Make the go implementation normalize 0.0 properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maljub01