Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch the default queues value from the env #8

Closed
wants to merge 1 commit into from
Closed

Fetch the default queues value from the env #8

wants to merge 1 commit into from

Conversation

meatballhat
Copy link

mostly so that purely env-based configurations are possible, as this is the only flag (I think?) that causes an exit when not provided.

mostly so that purely env-based configurations are possible, as this is
the only flag (I think?) that causes an exit when not provided.
@meatballhat
Copy link
Author

For reference, I'm using goworker over here in a docker + ansible context where it'd be super handy to keep all of my configuration in an env dict/hash for ease of things like upstart conf templates.

@benmanns
Copy link
Owner

benmanns commented Dec 6, 2013

Hey @meatballhat, thanks for the PR. Sorry it's taken so long to get back to you.

I'm hesitant to have some config as flags, with other configs only as environment variables. The $REDIS_URL and $REDIS_PROVIDER variables serve for compatibility with Resque and Sidekiq. For now, you can run your process as goworker -queues=$QUEUES.

However, I would be interested in a clean way to implement ENV-based configuration. Perhaps something like kelseyhightower/envconfig would make sense. What do you think?

@meatballhat
Copy link
Author

@benmanns No worries 😺 I'd say the envconfig way seems reasonable enough. I'm guessing you're wanting to avoid this kind of repetition (?):

@meatballhat meatballhat closed this Dec 9, 2015
skaurus referenced this pull request in skaurus/goworker Jul 26, 2022
Added: '-force-prune' to remove workers not on the heartbeat list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants