Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-extraneous-dependencies: add support/option for peerDependencies (#423) #428

Merged
merged 4 commits into from
Jul 13, 2016

Conversation

jfmengels
Copy link
Collaborator

no-extraneous-dependencies: add support/option for peerDependencies (#423)

@jfmengels jfmengels force-pushed the extraneous-allow-peer-dependencies branch 2 times, most recently from 15b37d6 to 2da02a7 Compare July 9, 2016 13:11
@jfmengels
Copy link
Collaborator Author

Modified so that peerDependencies is true by default

@jfmengels jfmengels force-pushed the extraneous-allow-peer-dependencies branch from 445282d to 08e2c2a Compare July 13, 2016 11:28
@jfmengels
Copy link
Collaborator Author

Why the extra "electron" test?

Because I like copy-pasting and didn't notice I copied too much 😄 Removed 👍

@benmosher
Copy link
Member

:shipit:

Good on your end? I'm ready to merge once master is passing on Travis.

@jfmengels
Copy link
Collaborator Author

jfmengels commented Jul 13, 2016

All good for me if the tests pass 👍

@coveralls
Copy link

coveralls commented Jul 13, 2016

Coverage Status

Coverage remained the same at 97.614% when pulling 08e2c2a on extraneous-allow-peer-dependencies into 71afde7 on master.

@benmosher
Copy link
Member

coverage should bump back up once the OSX builds complete. also the failures on the Travis/push build are fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants