Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Make the ReconnectingSocket object accessible outside of WebSocketClient #608

Merged
merged 3 commits into from
Sep 18, 2021

Conversation

hjoelr
Copy link
Contributor

@hjoelr hjoelr commented Sep 17, 2021

Sometimes it may be necessary to access this object to make changes, or more likely just to determine its current status.

Sometimes it may be necessary to access this object to make changes, or more
likely just to determine its current status.
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #608 (4c951d8) into main (3dfeb77) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #608   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          506       506           
  Branches        39        39           
=========================================
  Hits           506       506           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/client/WebSocketClient.ts 100.00% <ø> (ø)

@bennycode bennycode merged commit 91eca2f into bennycode:main Sep 18, 2021
@bennycode
Copy link
Owner

Thanks for your PR. :) It's live with coinbase-pro-node v3.0.8.

@hjoelr hjoelr deleted the feature/make-socket-public branch September 19, 2021 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants