This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add WebSocket connected() function #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #656 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 509 531 +22
Branches 39 39
=========================================
+ Hits 509 531 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Hi @hjoelr, let's make it a getter function. The |
hjoelr
force-pushed
the
feature/ws-connected-helper-function
branch
from
51ff268
to
92249e4
Compare
|
Thanks again @hjoelr. 🙏 All your changes are now live with v3.1.0 -> https://www.npmjs.com/package/coinbase-pro-node/v/3.1.0 |
|
@bennycode You're welcome. My next contribution will hopefully be based off the idea in #421. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a helper function for determining if the underlying WebSocket has not yet closed. Needing to know this was the main reason I requested #608 to make the socket public. If you think it'd be okay, we could probably revert that change with this. The issue is that some people may be relying on the socket being public now.
Also, I wasn't sure what your preference would be a
connected()function or a getter property. I can change if you prefer that.