Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring logger_class with statsd_host #1188

Merged
merged 3 commits into from
Feb 19, 2016
Merged

Allow configuring logger_class with statsd_host #1188

merged 3 commits into from
Feb 19, 2016

Commits on Feb 19, 2016

  1. Allow configuring logger_class with statsd_host 

    Currently if you configure statsd_host, a configured logger_class will never be used.

I think this makes a user configured logger class always take priority.

(This is PoC change, I will come back and add tests/docs if it's worth pursuing)
    @bloodearnest
    bloodearnest committed Feb 19, 2016
    Configuration menu
    Copy the full SHA
    f68a043 View commit details
    Browse the repository at this point in the history

  2. Always use the the user configured logger class. 

    Previously, configuring statsd_host would override the configured class
    @bloodearnest
    bloodearnest committed Feb 19, 2016
    Configuration menu
    Copy the full SHA
    34b595e View commit details
    Browse the repository at this point in the history

  3. Update docs - more explicit info on logger_class

    @bloodearnest
    bloodearnest committed Feb 19, 2016
    Configuration menu
    Copy the full SHA
    b05286e View commit details
    Browse the repository at this point in the history