-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --server_name and --no_server_name options #825 #1384
Add --server_name and --no_server_name options #825 #1384
Conversation
…eader in the response, and `no_server_name` to disable returning the `Server` header.
Thanks for the patch. I'm not sure I like the idea to add another option for gunicorn. Maybe just removing the signature is enough? Why would like someone replace the signature of Gunicorn? |
I'm fine for both options, but the CLI flags should be hyphenated, not snake_case, to be consistent with the existing flags. |
My mistake. The CLI flags are hyphenated, just not in the documentation. |
server_name | ||
~~~~~~~~~~~~~~~~~~~ | ||
|
||
* ``--server_name STRING`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and below, is what I am referring to when I talk about hyphenation.
``--server-name STRING``
No?
why are you closjng the issue? has it been solved? |
It's been 4 years and still no solution? Too bad |
@RKursatV it has been decided to not do it. The version part has been removed from the name. There is another ticket about it. |
Set
--server_name
to return a different HTTP Server response header thangunicorn/19.6.0
.Set
--no_server_name
to no longer return the header.