Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align license with OSI template #2885

Closed
wants to merge 2 commits into from
Closed

align license with OSI template #2885

wants to merge 2 commits into from

Conversation

lsmith77
Copy link

This will ensure that GitHub will properly detect the license.

licensee detect .
License:        MIT
Matched files:  LICENSE
LICENSE:
  Content hash:  4c2c763d64bbc7ef2e58b0ec6d06d90cee9755c9
  Attribution:   Copyright 2009-2018 (c) Benoît Chesneau <benoitc@e-engura.org>, 2009-2015 (c) Paul J. Davis <paul.joseph.davis@gmail.com>
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       MIT

apollo13
apollo13 reviewed Jan 2, 2023
View reviewed changes
README.rst
@@ -62,12 +62,6 @@ Contributing
See `our complete contributor's guide <CONTRIBUTING.md>`_ for more details.


License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it wouldn't hurt to keep this.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Let just change the LICENSE file possibly. Can you provide this change?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump?

@benoitc
Copy link
Owner

benoitc commented Jan 17, 2023 •
edited
Loading

from where is coming this license detection? Seems like a patch should be sent to github possibly instead of removing readability. Is this possible?

@lsmith77
Copy link
Author

from where is coming this license detection? Seems like a patch should be sent to github possibly instead of removing readability. Is this possible?

you can run https://github.com/licensee/licensee locally

the tool gets confused if there are multiple references to licenses.

@benoitc
Copy link
Owner

benoitc commented May 7, 2023

i am not sure I like this change. This makes it barely unreadable. What I f I have multiple copyrights date. Imo this githb code should be fixed instead of asking to projects to make their list of copyrights unreadable.

@benoitc benoitc added the Deploy label May 10, 2023
@tilgovi
Copy link
Collaborator

tilgovi commented Dec 29, 2023

Stalled. Closing.

@tilgovi tilgovi closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitc benoitc benoitc left review comments

@apollo13 apollo13 apollo13 left review comments

Assignees
No one assigned
Labels
Deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsmith77 @benoitc @tilgovi @apollo13