Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore, and from now on CI-test for entry point #3108

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

pajod
Copy link
Contributor

@pajod pajod commented Dec 7, 2023

  1. We want the built package to install a "gunicorn" script.
  2. We want that script to work and reasonable output when called gunicorn --help
    • Have CI assert that
  3. We want the entry point to work more or less interchangeably with python3 -m gunicorn (that is: __main__.py)
    • Have CI assert that

Driveby fixes:

  1. GitHub actions finish faster when the setup-python knows which dependencies are reused
    • potentially unwanted effects for private dependencies - OK, we only use PyPi hosted (and occasionally public GitHub)
    • Verification: In section "Install Dependencies" logs will say "Using cached" in place of "Downloading"
  2. Some python tools fail to agree with GitHub runners about console capabilities.
    • Enforce color output
    • Verification: I have seen it work.
  3. Removed cryptography dependency again.
    • commit 91cb3dc does not justify including it, if it was indeed needed maybe it should be referenced elsewhere (somewhere not parsed by CI)
    • Verification: Removing it did not noticeably break or slow down CI
  4. GitHub actions are versioned. If they improve things, we want that.
    • Since we do not depend on versioned features, we can just bump the major version and automatically use a recent release.
    • Verification: Did not noticeably break or slow down CI

@pajod pajod force-pushed the patch-githubactions branch 2 times, most recently from ac26734 to 080374c Compare December 7, 2023 20:05
@pajod pajod mentioned this pull request Dec 8, 2023
@pajod pajod changed the title github actions: cache and test run_module (-m) restore, and from now on CI-test for entry point Dec 9, 2023
@tilgovi tilgovi merged commit f9e61b1 into benoitc:master Dec 29, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyproject.toml does not declare entryopints.
3 participants