Fix python setup.py test won't actually download test dependencies
#833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it's more than just replacing PyTest base class, close for now. |
|
:sad: |
|
@wooparadog mmm couldn't you add all deps from |
|
@benoitc but tests don't need sphinx nor sphinx_rtd_theme... |
|
@benoitc oh, and by the way, all deps in |
| user_options = [ | ||
| ("cov", None, "measure coverage") | ||
| ] | ||
|
|
||
| def initialize_options(self): | ||
| TestCommand.initialize_options(self) |
There was a problem hiding this comment.
Is there a reason to not using super() here?
There was a problem hiding this comment.
yeah...it's an old style class...
|
LGTM. @berkerpeksag ok for you too? |
|
LGTM too, I've squashed the commits and merged in 2753aac. Thanks @wooparadog :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://pytest.org/latest/goodpractises.html#integration-with-setuptools-test-commands