Fix `python setup.py test` won't actually download test dependencies #833

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@wooparadog

This comment has been minimized.

Show comment
Hide comment
@wooparadog

wooparadog Jul 30, 2014

Contributor

Oh, it's more than just replacing PyTest base class, close for now.

Contributor

wooparadog commented Jul 30, 2014

Oh, it's more than just replacing PyTest base class, close for now.

@wooparadog wooparadog closed this Jul 30, 2014

@georgexsh

This comment has been minimized.

Show comment
Hide comment
@georgexsh

georgexsh Jul 30, 2014

Contributor

:sad:

Contributor

georgexsh commented Jul 30, 2014

:sad:

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jul 30, 2014

Owner

@wooparadog mmm couldn't you add all deps from requirement_dev.txt in test_requires ?

Owner

benoitc commented Jul 30, 2014

@wooparadog mmm couldn't you add all deps from requirement_dev.txt in test_requires ?

@wooparadog

This comment has been minimized.

Show comment
Hide comment
@wooparadog

wooparadog Jul 31, 2014

Contributor

@benoitc but tests don't need sphinx nor sphinx_rtd_theme...

Contributor

wooparadog commented Jul 31, 2014

@benoitc but tests don't need sphinx nor sphinx_rtd_theme...

@wooparadog

This comment has been minimized.

Show comment
Hide comment
@wooparadog

wooparadog Jul 31, 2014

Contributor

@benoitc oh, and by the way, all deps in requirement_dev.txt are already in test_requires...

Contributor

wooparadog commented Jul 31, 2014

@benoitc oh, and by the way, all deps in requirement_dev.txt are already in test_requires...

@wooparadog wooparadog reopened this Jul 31, 2014

user_options = [
("cov", None, "measure coverage")
]
def initialize_options(self):
+ TestCommand.initialize_options(self)

This comment has been minimized.

@berkerpeksag

berkerpeksag Jul 31, 2014

Collaborator

Is there a reason to not using super() here?

@berkerpeksag

berkerpeksag Jul 31, 2014

Collaborator

Is there a reason to not using super() here?

This comment has been minimized.

@wooparadog

wooparadog Jul 31, 2014

Contributor

yeah...it's an old style class...

@wooparadog

wooparadog Jul 31, 2014

Contributor

yeah...it's an old style class...

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Aug 1, 2014

Owner

LGTM. @berkerpeksag ok for you too?

Owner

benoitc commented Aug 1, 2014

LGTM. @berkerpeksag ok for you too?

@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Aug 1, 2014

Collaborator

LGTM too, I've squashed the commits and merged in 2753aac. Thanks @wooparadog :)

Collaborator

berkerpeksag commented Aug 1, 2014

LGTM too, I've squashed the commits and merged in 2753aac. Thanks @wooparadog :)

@wooparadog wooparadog deleted the wooparadog:fix-setup-test branch Aug 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment