Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to send https request on OTP 22.1 #591

Closed
yjh0502 opened this issue Sep 20, 2019 · 15 comments
Closed

Failed to send https request on OTP 22.1 #591

yjh0502 opened this issue Sep 20, 2019 · 15 comments

Comments

@yjh0502
Copy link

yjh0502 commented Sep 20, 2019

Hackney returns {error,{option,server_only,honor_cipher_order}} with https url, starting from OTP 22.1.

Here's a location on ssl library which causes a problem. It seems that honor_cipher_order have not been work on client connections so they started blocking it.
https://github.com/erlang/otp/blob/bf2dfb7f51fa50d832f4dc4e4e271e7a6df93629/lib/ssl/src/ssl.erl#L1703-L1706

Commenting following line fixes the problem.
https://github.com/benoitc/hackney/blob/master/src/hackney_ssl.erl#L68

@yjh0502 yjh0502 changed the title ssl:connect does not support honer_cipher_order from OTP 22.1 Failed to send https request on OTP 22.1 Sep 20, 2019
@gmile
Copy link
Contributor

gmile commented Sep 21, 2019

FWIW I just noticed a similar line with honor_cipher_order was removed from hex back in January hexpm/hex@f34518e

@ruudk
Copy link

ruudk commented Sep 23, 2019

Is there a workaround to this issue?

@lasseebert
Copy link

@ruudk, I think only workarounds are downgrade erlang or fork hackney.

@benoitc
Copy link
Owner

benoitc commented Sep 23, 2019

or wait i merge the pr tonight.

@benoitc
Copy link
Owner

benoitc commented Sep 23, 2019

fixed in latest master

@benoitc benoitc closed this as completed Sep 23, 2019
@hernanat
Copy link

hernanat commented Sep 24, 2019

@benoitc are you planning a release for this as well? Not too familiar with your project or release strategy, sorry if it's a silly question.

@benoitc
Copy link
Owner

benoitc commented Sep 24, 2019

@hernanat i will make a release today. Was too late yesterday for it :)

@ggwc82
Copy link

ggwc82 commented Sep 24, 2019

Hi, can you please increment the Hackney version so that we can pull in changes from Hex for this? Thanks

@mdarby
Copy link

mdarby commented Sep 25, 2019

Can we get a new version cut? This is a big blocker. I appreciate it!

@ltj
Copy link

ltj commented Sep 25, 2019

While waiting for a new hex release, you can point deps to the github master branch or downgrade to OTP 22.0.7. Both are perfectly viable options ;)

@timbuckley
Copy link

If anyone is having problems down the chain on Elixir and finds yourself here, here's a quick fix for now: edgurgel/httpoison#393

To fix: Put this in your mix.exs

{:hackney, github: "benoitc/hackney", override: true}

@benoitc
Copy link
Owner

benoitc commented Sep 25, 2019

@mdarby just released the version 1.15.2 . Was side-tracked. Hope it helps :)

@ruudk
Copy link

ruudk commented Sep 26, 2019

Because nobody replied yet: Tested it and verified that it works. Thanks @benoitc ❤️

@sebbean
Copy link

sebbean commented Dec 10, 2019

thanks boize @lxqnt appreciates

mucho calor!

zhyu added a commit to zhyu/nadia that referenced this issue Dec 24, 2019
kaaboaye added a commit to kaaboaye/tesla that referenced this issue Jan 12, 2020
Due to unannounced breaking change in OTP version 22.1 hackney below the version 1.15.2 stopped working.

Older versions are throwing `{:option, :server_only, :honor_cipher_order}` on OTP >= 22.1 and 1.15.2 fixes this issue.

Reference:
benoitc/hackney#591
edgurgel/httpoison#393
teamon pushed a commit to elixir-tesla/tesla that referenced this issue Jan 13, 2020
Due to unannounced breaking change in OTP version 22.1 hackney below the version 1.15.2 stopped working.

Older versions are throwing `{:option, :server_only, :honor_cipher_order}` on OTP >= 22.1 and 1.15.2 fixes this issue.

Reference:
benoitc/hackney#591
edgurgel/httpoison#393
stueccles pushed a commit to stueccles/analytics-elixir that referenced this issue Apr 22, 2020
TsuyoshiUshi added a commit to TsuyoshiUshi/teslamate that referenced this issue Jul 15, 2022
flooppmtn pushed a commit to flooppmtn/teslamate that referenced this issue Aug 24, 2022
ClarkWalker pushed a commit to ClarkWalker/wall that referenced this issue Nov 12, 2022
backspace added a commit to backspace/prison-rideshare-api that referenced this issue Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests