Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please, change the generated URLs from absolute to relative paths #65

Closed
jguillod opened this issue Apr 14, 2012 · 2 comments
Closed

please, change the generated URLs from absolute to relative paths #65

jguillod opened this issue Apr 14, 2012 · 2 comments

Comments

@jguillod
Copy link

Currently, the generated URLs are absolute paths. Could you change to be relative paths? This implies to change:

  1. 2x lines in the addEvent('keyup') of the application.js file (about line 250 + 260)
    • from:
      resultList.push('<li><a href="/'+resultURL+'">'+resultText+' <span>Section '+resultSection+'</span></a></li>');
    • to:
      resultList.push('<li><a href="'+resultURL+'">'+resultText+' <span>Section '+resultSection+'</span></a></li>');
  2. at some places when generating the public folder.

This will allow us to deploy in any sub-folder of a web server. Of course I have made changes semi-automatically since the prefixing / has just to be removed (+application.js fix)…

Thanks a lot ! I have been searching for a long while to find a quick reference to dom javascript… I have been able to generate a pristine copy of developers.whatwg.org on osx which is a must for a developer working in the french countryside with low speed internet connexion.
Regards

@benschwarz
Copy link
Owner

I'd be happy to make the change…

But did you know that the spec is using ApplicationCache and will already work offline? Or that its always stored in your (modern) browser? Try unlugging / turning wireless off then head to developers.whatwg.org—It should be fully functional.

@benschwarz
Copy link
Owner

Ping @jguillod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants