Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow config.active_job.queue_adapter = :good_job to work #5

Closed
bensheldon opened this issue Mar 4, 2020 · 1 comment · Fixed by #28
Closed

Allow config.active_job.queue_adapter = :good_job to work #5

bensheldon opened this issue Mar 4, 2020 · 1 comment · Fixed by #28

Comments

@bensheldon
Copy link
Owner

bensheldon commented Mar 4, 2020 •
edited
Loading

Seems like it's just necessary to define ActiveJob::QueueAdapters::GoodJob

...and will probably want a :good_job_inline variant as well for development environment.
@bensheldon
Copy link
Owner Author

To go by convention, thinking:

  • Development: inline
  • Test: inline
  • Production: executable

I think this should be turned into a mode, rather than an option.

@bensheldon bensheldon mentioned this issue Jul 14, 2020
Merged
bensheldon pushed a commit that referenced this issue Nov 26, 2023
@netikular
Merge pull request #5 from Paradem/correct_cli
9e32fc4 
Over wrote something by mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow configuration of Rails queue adapter with :good_job bensheldon/good_job
1 participant
@bensheldon