Collapse Dashboard params by default #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensheldon
approved these changes
May 26, 2021
There was a problem hiding this comment.
I think this is great 👍 I left some HTML suggestions.
This does make me think about how to make specific jobs easier to find. I'm a big user of CMD-F to search within a page and collapsing content does make that more difficult.
I'm good moving forward with this and seeing if we get feedback. Some future ideas:
- Adding a toggle to the column header that toggles them all
- A searchbar function in the header; another benefit of postgres is fulltext search (even without an index)
Having expanded all of the params is very noisy. With this change we can also pack more jobs on page
morgoth
force-pushed
the
collapsable-params
branch
from
3c3be87
to
5154330
Compare
bensheldon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having expanded all of the params is very noisy. With this change we can also pack more jobs on page