File logger should automatically roll log file and destroy timers if …

…removed from logging stack.
bensurtees · Dec 23, 2011 · 19fdbe1 · 19fdbe1
1 parent dbd06c2
commit 19fdbe1
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/Lumberjack/DDFileLogger.m b/Lumberjack/DDFileLogger.m
@@ -686,6 +686,13 @@ - (void)rollLogFileNow
 	}
 
 	currentLogFileInfo = nil;
+
+	if (rollingTimer)
+	{
+		dispatch_source_cancel(rollingTimer);
+		dispatch_release(rollingTimer);
+		rollingTimer = NULL;
+	}
 }
 
 - (void)maybeRollLogFileDueToAge
@@ -837,6 +844,13 @@ - (void)logMessage:(DDLogMessage *)logMessage
 	}
 }
 
+- (void)willRemoveLogger
+{
+	// If you override me be sure to invoke [super willRemoveLogger];
+
+	[self rollLogFileNow];
+}
+
 - (NSString *)loggerName
 {
 	return @"cocoa.lumberjack.fileLogger";