LNHANCE mutinynet (CHECKSIGFROMSTACK and INTERNALKEY) #2
Conversation
For completeness, also updates FormatScriptFlags to report on any bits that do not match a script flag.
reardencode
changed the title
always active on regtest active from 2024-01-12 until 2034-01-12 on signet never active on testnet, mainnet
reardencode
force-pushed
the
lnhance-mutiny
branch
from
da3187b
to
bfac0a0
Compare
Testing is minimal, but so is the code.
Some code and ideas from Elements by stevenroose, and sanket1729 Porting help from moonsettler Tests added to the transaction tests framework.
reardencode
force-pushed
the
lnhance-mutiny
branch
from
bfac0a0
to
670cded
Compare
| } else if (pubkey_in.size() == 32) { | ||
| if (!success) return true; | ||
| if (sig.size() != 64) return set_error(serror, SCRIPT_ERR_SCHNORR_SIG_SIZE); | ||
|
|
||
| XOnlyPubKey pubkey{pubkey_in}; | ||
|
|
||
| if (!pubkey.VerifySchnorr(msg, sig)) return set_error(serror, SCRIPT_ERR_SCHNORR_SIG); |
There was a problem hiding this comment.
does this mean you can do schnorr sigs with segwit v0 and p2sh? is that intended?
There was a problem hiding this comment.
Yes, that is intended. Since we're introducing new sigops, we have the option to add key type detection similar to Tapscript keys (as leveraged in APO).
| // Pubkeys of length 33 are only constrained in legacy and segwitv0. In these script types only those beginning | ||
| // with 0x02 or 0x03 are constrained. Others are unknown pubkey types. |
There was a problem hiding this comment.
if schnorr is allowed in non-taproot then why forbid ecdsa for taproot?
There was a problem hiding this comment.
No strong opinion there - would love to discuss on the BIP whether we want both on both!
bitcoin/bips#1535 <-- here's the bips PR for discussing design things.
| return false; | ||
| } | ||
|
|
||
| if (msg.size() != 32) return set_error(serror, SCRIPT_ERR_INVALID_DATA_LENGTH); |
There was a problem hiding this comment.
should different message sizes be left for future upgrades
There was a problem hiding this comment.
For ECDSA only size 32 is possible - any size message can be done by adding a OP_SHA256 first.
|
I think it's far too early an idea to be putting into our mutinynet. maybe once the code is solid and there's decent desire for it. |
|
Hi Tony, what's not solid about the code? CSFS has been in Liquid and BCH for years, and INTERNALKEY is simply an alternative to APO's magic This combination of features can be used to build a better LN-Symmetry than APO. We're in the process of prototyping that, and would like to test it on a public signet such as mutinynet. |
|
The PR into core is just a week old and there's still conflicting discussions around it. Your INTERNALKEY bip is also just a week old. I don't think everyone's new op codes should just go into mutinynet the second they create one. That's the whole point of everyone being able to spin up their own signet. |
|
FWIW, COVTOOLS was merged to MutinyNet 15 days after the PR to core was opened :) |
|
Converted this to a draft while I work through AJ's review on my similar PR to inquisition. Will port those changes over here and undraft when the time comes. |
This adds CHECKSIGFROMSTACK and INTERNALKEY to mutinynet for review and testing.
(Related to bitcoin#29198)