Add "latest" tag to BentoML user-facing docker image #1046
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
- Coverage 63.54% 62.80% -0.75%
==========================================
Files 125 125
Lines 8274 8132 -142
==========================================
- Hits 5258 5107 -151
- Misses 3016 3025 +9
Continue to review full report at Codecov.
|
docker/model-server/release.sh
Outdated
| echo "Tag and push 'latest'.." | ||
| docker tag bentoml/model-server:"$BENTOML_VERSION" bentoml/model-server:latest | ||
| docker push bentoml/model-server:latest |
There was a problem hiding this comment.
Thoughts on tagging with latest in the build step? moby/moby#15780
There was a problem hiding this comment.
That way push step can just be docker push bentoml/model-server and it will figure out which tags need to be pushed on its own
There was a problem hiding this comment.
Great idea!
Do you know how does docker push bentoml/model-server figure out which tags needs to be pushed? I may have other tags that are used only for local development and want to avoid pushing those to docker hub.
There was a problem hiding this comment.
Ok turns out docker push without a specified tag will push all local dev images too so that may not be ideal. I guess we can just leave it at docker push bentoml/model-server:latest && docker push bentoml/model-server:"$BENTOML_VERSION"
There was a problem hiding this comment.
That makes sense, thanks for confirming!
Thanks for the suggestion @jackyzha0, it is so much cleaner this way! |
|
@yubozhao looks like those two tests are flaky on CI, could you help look into it? |
|
@parano yeah. I will try figure out why. From the Github actions, it seems like the unit tests and the API server tests are flaky right? |
* Add latest tag to BentoML user-facing docker image * updates
Description
latesttag when releasing a new docker image that is user-facing.latesttaglatesttag can cause issues when used in a production environment, although it is very convenient when a user is just starting out. We should add a warning about it in our YataiService deployment guide.Motivation and Context
For context, see PR #1045 from @danield137 and slack discussions with @jackyzha0 here: https://bentoml.slack.com/archives/CK8PQU2JY/p1597872697082800
How Has This Been Tested?
Tested locally, published
latesttag for release 0.8.6Types of changes
Component(s) if applicable
Checklist:
./dev/format.shand./dev/lint.shscript have passed(instructions).