Add ability to add multiple tags with docker build #15780

mountkin · 2015-08-23T16:06:29Z

Closes #863

docker build -t tag1 -t tag2:v1 -t tagN .

TODO:

Reach a consensus on whether we need this feature
Complete the test cases

Signed-off-by: Shijiang Wei mountkin@gmail.com

cpuguy83 · 2015-08-24T14:07:08Z

I don't see a good reason to -1 this, so +1.

thaJeztah · 2015-08-26T06:31:25Z

I'm +1, and it was already approved on in #863 (comment), but a very long time ago 😄

cpuguy83 · 2015-08-26T14:48:17Z

builder/job.go

@@ -50,7 +50,7 @@ var validCommitCommands = map[string]bool{
 type Config struct {
 	DockerfileName string
 	RemoteURL      string
-	RepoName       string
+	RepoName       interface{}


We don't want to use an interface{} here.
Entrpoiny/Cmd have some special parsing you can look at (in runconfig/config.go) to handle this.

Cool! I think we can abstract the parser in runconfig to "opts" package so that we can reuse the code here.

@cpuguy83 ~~this will depend on #15913~~
I found change the RepoName field to []string is okay. No BC break introduced.

mountkin · 2015-08-30T15:04:55Z

Test added. The failure of the experimental test is not caused by this PR.

thaJeztah · 2015-08-31T23:22:07Z

integration-cli/requirements.go

@@ -40,7 +40,7 @@ var (
 		func() bool {
 			// Set a timeout on the GET at 15s
 			var timeout = time.Duration(15 * time.Second)
-			var url = "https://hub.docker.com"
+			var url = "http://www.baidu.com"


not sure this should be changed? (also this changes from a https:// to a http:// domain)

Ah, sorry. It's quite slow to connect to docker hub in China so I changed the url temporarily but forgot to change it back before pushing to github.

Heh, I thought that would probably be the case; given that we have quite some contributors from China; do you think we should have some alternatives?

I think it's okay to leave it as it is. But I have to be more careful if I change it again 😄
If in the future other contributors run into the same problem as mine, I think we can allow the user to pass the URL to check from an environment variable when running the tests.

thaJeztah · 2015-09-01T06:13:38Z

@mountkin I see you updated the PR; is this ready for another review?

mountkin · 2015-09-01T06:33:14Z

@thaJeztah I think it's ready for code review now.

tiborvass · 2015-09-04T00:51:10Z

@mountkin what's the usecase? I don't feel strongly either way, don't mind if it gets in, don't mind if it doesn't.

mountkin · 2015-09-04T02:03:14Z

@tiborvass it's useful when I want to build an image and push it to multiple registries. Without this feature I have to run "docker tag" after the build.
Other usecases can be found in #863

tiborvass · 2015-09-04T14:34:05Z

Fair enough, weak +1 for design

calavera · 2015-09-22T04:14:09Z

It looks useful. Let's move it forward.

calavera · 2015-09-22T04:14:47Z

@mountkin do you mind rebase and making sure we have proper tests and documentation for this?

mountkin · 2015-09-22T14:50:00Z

@calavera rebased and updated docs. Thanks for helping to move this forward.

calavera · 2015-09-22T16:26:51Z

LGMT

thaJeztah · 2015-10-21T03:37:23Z

Thanks @mountkin, docs LGTM, but unfortunately this needs a rebase 😢

ping @moxiegirl PTAL

mountkin · 2015-10-21T03:48:17Z

@thaJeztah rebased 😃

thaJeztah · 2015-10-21T04:03:03Z

Thanks @mountkin !

ping @jamtur01 @moxiegirl @SvenDowideit ptal

moxiegirl · 2015-10-22T16:32:50Z

docs/reference/api/docker_remote_api_v1.21.md

-        the resulting image in case of success.
+-   **t** – A name and optional tag to apply to the image in the `name:tag` format.
+        If you omit the `tag` the default `latest` value is assumed.
+        You can provide one or more **t** parameters.


needs ticks not bold around the t so t

Signed-off-by: Shijiang Wei <mountkin@gmail.com>

mountkin · 2015-10-23T17:04:17Z

Updated the docs per @moxiegirl's suggestions.
Thanks all the reviewers for the patience. 😃

thaJeztah · 2015-10-23T17:21:26Z

Thanks @mountkin, docs LGTM!

ping @SvenDowideit @moxiegirl PTAL

moxiegirl · 2015-10-23T19:06:19Z

LGTM! Thank you @mountkin.

vdemeester · 2015-10-23T19:31:32Z

yay 🎉

thaJeztah · 2015-10-23T20:50:32Z

Al green! Merging. Thanks @mountkin !

Add ability to add multiple tags with docker build

liyaka · 2015-10-26T08:39:24Z

What about pushing multiple tags in one command as well?
For example I have an image with 2 tags xx:1.3-latest and xx:1.3.58. At the moment I have to push the same image twice which adds a few minutes to my build time...

thaJeztah · 2015-10-26T11:17:36Z

@liyaka there are still some outstanding issues / improvements to be made to push/pull, it has been decided to uphold new features in that until those improvements are made.

Having said that; yes it would be nice to have :-)

SimenB · 2016-09-01T15:55:57Z

@thaJeztah Any news on multiple tags in single push? 😄

stevvooe · 2016-09-01T18:52:46Z

@SimenB We want to reserve the syntax in docker push to allow for specifying alternate remotes. For example, we'd like to be able to say docker push myregistry:5000 image. I could see adding a -t flag, as well, but there is no active proposal that covers these two use cases.

GordonTheTurtle added area/distribution status/0-triage labels Aug 23, 2015

calavera added status/1-design-review and removed status/0-triage labels Aug 24, 2015

cpuguy83 reviewed Aug 26, 2015
View reviewed changes

mountkin mentioned this pull request Aug 28, 2015

abstract the string slice struct to stringutils package #15913

Merged

mountkin force-pushed the build-multi-tags branch 2 times, most recently from e0a9033 to b206b2c Compare August 30, 2015 14:02

mountkin changed the title ~~[WIP] Add ability to add multiple tags with docker build~~ Add ability to add multiple tags with docker build Aug 30, 2015

mountkin force-pushed the build-multi-tags branch from b206b2c to d0cbfa3 Compare August 30, 2015 14:16

mountkin force-pushed the build-multi-tags branch from d0cbfa3 to 0f94106 Compare August 31, 2015 04:23

thaJeztah reviewed Aug 31, 2015
View reviewed changes

mountkin force-pushed the build-multi-tags branch from 0f94106 to 2195827 Compare September 1, 2015 02:29

calavera added status/2-code-review and removed status/1-design-review labels Sep 22, 2015

calavera added the impact/changelog label Sep 22, 2015

mountkin force-pushed the build-multi-tags branch 2 times, most recently from f046fe5 to edc2518 Compare September 22, 2015 14:39

thaJeztah mentioned this pull request Oct 21, 2015

Add ability to add multiple tags with docker build #863

Closed

mountkin force-pushed the build-multi-tags branch from 37f000a to fc42040 Compare October 21, 2015 03:47

moxiegirl reviewed Oct 22, 2015
View reviewed changes

mountkin force-pushed the build-multi-tags branch from fc42040 to 6c86ab3 Compare October 23, 2015 16:58

Add ability to add multiple tags with docker build

c2eb37f

Signed-off-by: Shijiang Wei <mountkin@gmail.com>

mountkin force-pushed the build-multi-tags branch from 6c86ab3 to c2eb37f Compare October 23, 2015 17:00

thaJeztah added a commit that referenced this pull request Oct 23, 2015

Merge pull request #15780 from mountkin/build-multi-tags

448398c

Add ability to add multiple tags with docker build

thaJeztah merged commit 448398c into moby:master Oct 23, 2015

mountkin deleted the build-multi-tags branch November 10, 2015 11:30

thaJeztah added this to the 1.10.0 milestone Jan 16, 2016

This was referenced Jan 16, 2016

Bump version to v1.10.0 #19370

Merged

docker build with several --tag options depends on tags order #19297

Closed

Bukharovsi mentioned this pull request Feb 1, 2017

Another way to add several arguments with the same names adambrett/php-shell-wrapper#23

Closed

apeschel mentioned this pull request May 18, 2017

Documentation incorrect -- Docker v1.10 or higher required sbt/sbt-native-packager#981

Closed

NicolasMahe mentioned this pull request May 31, 2018

Changelog and versions mesg-foundation/engine#174

Merged

pkoenig10 mentioned this pull request Jan 2, 2019

Support tag task name for 'tags' palantir/gradle-docker#205

Merged

jackyzha0 mentioned this pull request Aug 30, 2020

Add "latest" tag to BentoML user-facing docker image bentoml/BentoML#1046

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to add multiple tags with docker build #15780

Add ability to add multiple tags with docker build #15780

mountkin commented Aug 23, 2015

cpuguy83 commented Aug 24, 2015

thaJeztah commented Aug 26, 2015

cpuguy83 Aug 26, 2015

mountkin Aug 26, 2015

mountkin Aug 30, 2015

mountkin commented Aug 30, 2015

thaJeztah Aug 31, 2015

mountkin Sep 1, 2015

thaJeztah Sep 1, 2015

mountkin Sep 1, 2015

thaJeztah commented Sep 1, 2015

mountkin commented Sep 1, 2015

tiborvass commented Sep 4, 2015

mountkin commented Sep 4, 2015

tiborvass commented Sep 4, 2015

calavera commented Sep 22, 2015

calavera commented Sep 22, 2015

mountkin commented Sep 22, 2015

calavera commented Sep 22, 2015

thaJeztah commented Oct 21, 2015

mountkin commented Oct 21, 2015

thaJeztah commented Oct 21, 2015

moxiegirl Oct 22, 2015

mountkin commented Oct 23, 2015

thaJeztah commented Oct 23, 2015

moxiegirl commented Oct 23, 2015

vdemeester commented Oct 23, 2015

thaJeztah commented Oct 23, 2015

liyaka commented Oct 26, 2015

thaJeztah commented Oct 26, 2015

SimenB commented Sep 1, 2016

stevvooe commented Sep 1, 2016

Add ability to add multiple tags with docker build #15780

Add ability to add multiple tags with docker build #15780

Conversation

mountkin commented Aug 23, 2015

cpuguy83 commented Aug 24, 2015

thaJeztah commented Aug 26, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mountkin commented Aug 30, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thaJeztah commented Sep 1, 2015

mountkin commented Sep 1, 2015

tiborvass commented Sep 4, 2015

mountkin commented Sep 4, 2015

tiborvass commented Sep 4, 2015

calavera commented Sep 22, 2015

calavera commented Sep 22, 2015

mountkin commented Sep 22, 2015

calavera commented Sep 22, 2015

thaJeztah commented Oct 21, 2015

mountkin commented Oct 21, 2015

thaJeztah commented Oct 21, 2015

Choose a reason for hiding this comment

mountkin commented Oct 23, 2015

thaJeztah commented Oct 23, 2015

moxiegirl commented Oct 23, 2015

vdemeester commented Oct 23, 2015

thaJeztah commented Oct 23, 2015

liyaka commented Oct 26, 2015

thaJeztah commented Oct 26, 2015

SimenB commented Sep 1, 2016

stevvooe commented Sep 1, 2016