Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include handler's dependencies to the archived env yml #218

Merged
merged 2 commits into from
Jul 19, 2019

Conversation

yubozhao
Copy link
Contributor

Include handler's dependencies as well, when we are archiving bento service

@yubozhao yubozhao requested a review from parano July 18, 2019 22:18
@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #218 into master will decrease coverage by 0.11%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   52.45%   52.34%   -0.12%     
==========================================
  Files          53       55       +2     
  Lines        2949     3051     +102     
==========================================
+ Hits         1547     1597      +50     
- Misses       1402     1454      +52
Impacted Files Coverage Δ
bentoml/handlers/base_handlers.py 72.97% <100%> (+1.54%) ⬆️
bentoml/handlers/image_handler.py 59.37% <100%> (+0.86%) ⬆️
bentoml/handlers/fastai_image_handler.py 35.15% <100%> (+1.29%) ⬆️
bentoml/service.py 87.15% <100%> (+0.14%) ⬆️
bentoml/service_env.py 64.48% <75%> (+0.4%) ⬆️
bentoml/deployment/sagemaker/__init__.py 20.86% <0%> (-1.13%) ⬇️
bentoml/cli/click_utils.py 87.17% <0%> (-1.06%) ⬇️
bentoml/utils/log.py 100% <0%> (ø) ⬆️
bentoml/cli/deployment.py 54.54% <0%> (ø)
bentoml/cli/config.py 26.76% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed05bd1...2c7c2ed. Read the comment docs.

bentoml/service.py Outdated Show resolved Hide resolved
@yubozhao yubozhao marked this pull request as ready for review July 19, 2019 19:27
@parano parano added the LGTM label Jul 19, 2019
@parano parano merged commit 1984378 into bentoml:master Jul 19, 2019
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* Include handler's dependencies to the archived env yml

* Add tests for handler dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants