-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): respect api_server.workers
#3049
Conversation
13afba9
to
99faf91
Compare
99faf91
to
1245984
Compare
Codecov Report
@@ Coverage Diff @@
## main #3049 +/- ##
==========================================
+ Coverage 67.96% 67.97% +0.01%
==========================================
Files 113 113
Lines 10887 10888 +1
Branches 1908 1921 +13
==========================================
+ Hits 7399 7401 +2
Misses 3047 3047
+ Partials 441 440 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very minor nit, but otherwise looks great, thank you!
api_server.workers
from config correctlyapi_server.workers
wasn't parsed correctly
Co-authored-by: Sauyon Lee <2347889+sauyon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch and very lean fix. Thanks, @judahrand.
api_server.workers
wasn't parsed correctlyapi_server.workers
I will make a follow up PR to address some pylint issue. |
What does this PR address?
bentoml serve . --production
was ignoringapi_server.workers
inbento_configuration.yaml
. This is now fixed. I believe I've maintained the previous behaviour when the value was not manually set by the user.Fixes #(issue)
Before submitting:
guide on how to create a pull request.
make format
andmake lint
script have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.